Page Validation Rules in Lists an Issue for Windows

sjpadgett · October 18, 2017, 10:56pm

Remembering that the rule will become a JavaScript json variable, windows takes exception to using backward slash in string. Why Linux allows is a mystery to me.
So the existing rule:
{fname:{presence: {message:\Required field missing: Please enter the First name}}, lname:{presence: {message:\Required field missing: Please enter the Last name}}}

Should end up as:
{fname:{presence: {message:‘Required field missing: Please enter the First name’}}, lname:{presence: {message:‘Required field missing: Please enter the Last name’}}}

Not knowing the full intent, i’ll leave to someone else to address.

brady.miller · October 19, 2017, 10:03am

@sjpadgett ,

This is odd since there are quotes in the entries in Administration->Lists->Page Validation entries.
Maybe there is either weird escaping or odd things happening in json_encode/decode

In my linux environment on the User edit gui, I am seeing:
var collectvalidation = {rumple:{presence: {message:"Required field missing: Please enter the User Name"}}, stiltskin:{presence: {message:"Please enter the password"}}, fname:{presence: {message:"Required field missing: Please enter the First name"}}, lname:{presence: {message:"Required field missing: Please enter the Last name"}}};

-brady

sjpadgett · October 19, 2017, 10:24am

Quotes aren’t the issue in windows it is the ''backslash. I think linux see it as to escape the next character and windows looks for a path. I’ll post the window output in a moment.

brady.miller · October 19, 2017, 10:32am

Just so we are on the same page here, let me know the script where you pull the windows output from.

sjpadgett · October 19, 2017, 10:46am

{fname:{presence: {message:\Required field missing: Please enter the First name\}}, lname:{presence: {message:\Required field missing: Please enter the Last name\}}}

From

interface/usergroup/user_admin.php

PHP7.1 Win10. Users edit dialog.

brady.miller · October 20, 2017, 5:14pm

wow, that’s just plain weird. Appears that quotes are getting converted to \ in windows there.

Here’s what I get in the outputted source for user_admin.php on linux (PHP 7.0 and PHP7.1; tested on the development demos):

var collectvalidation = {fname:{presence: {message:"Required field missing: Please enter the First name"}}, lname:{presence: {message:"Required field missing: Please enter the Last name"}}};

brady.miller · October 20, 2017, 5:36pm

Wonder if it is that simply doing an echo on this php array:

github.com

openemr/openemr/blob/33ef407f6364a6eb1f75d7b0172708f84775dd25/library/validation/validate_core.php#L46


       $sql = sqlStatement("SELECT * " .
           "FROM `list_options` WHERE list_id=? AND title=?", array('page_validation', $title));
   }


   $dataArray=array();
   while ($row = sqlFetchArray($sql)) {
       $formPageNameArray = explode('#', $row['option_id']);
       $dataArray[$formPageNameArray[1]]=array('page_name' => $formPageNameArray[0] ,'rules' => $row['notes']);
   }


   return $dataArray;
}


/**this function creates client side validation rules for each <form> declared in list : Patient Validation - patient_validation
* @param $fileNamePath
* @output a generated javascript tag with the validation
*/
function validateUsingPageRules($fileNamePath)
{


   $path='';

Which is done here is causing different behavior in different environments:

github.com

openemr/openemr/blob/6485bc12d2454c945cde2026ab70c0666f1fb9ff/interface/usergroup/user_admin.php#L67


   $collectthis = $collectthis["user_form"]["rules"];
}
?>


<script language="JavaScript">


/*
* validation on the form with new client side validation (using validate.js).
* this enable to add new rules for this form in the pageValidation list.
* */
var collectvalidation = <?php echo($collectthis); ?>;


   function checkChange()
{
 alert("<?php echo addslashes(xl('If you change e-RX Role for ePrescription, it may affect the ePrescription workflow. If you face any difficulty, contact your ePrescription vendor.'));?>");
}
function submitform() {


   var valid = submitme(1, undefined, 'user_form', collectvalidation);
   if (!valid) return;

sjpadgett · October 20, 2017, 6:01pm

I’m betting it is a bug in the interpreter for windows. That or the interpreter simply is not seeing escape. I don’t get what we are escaping anyways. If it is to indicate the start of the string then wrong use case. Generally backslash in the string indicates a continuation of string or escape next special character. Notice there are not any quotes in page validation list params’ for users_admin edit…

{fname:{presence: {message:\Required field missing: Please enter the First name}}, lname:{presence: {message:\Required field missing: Please enter the Last name}}}

Even with quotes still doesn’t work on windows (only tested once with string quotes escaped with backslash). The only way it works is using quotes w/o backslash. Man i’m dyslexic today:)

brady.miller · October 20, 2017, 6:08pm

There is no escaping that is happening to this variable, which is why it’s even more weird. What do you see if you do print_r on the $dataArray variable in above function before it is returned?

sjpadgett · October 20, 2017, 6:31pm

From validate L46
{fname:{presence: {message:\Required field missing: Please enter the First name}}, lname:{presence: {message:\Required field missing: Please enter the Last name}}}</code

From user_admin L67:
From php array: {fname:{presence: {message:\Required field missing: Please enter the First name}}, lname:{presence: {message:\Required field missing: Please enter the Last name}}}

and JS array browser where error happens:
/*

validation on the form with new client side validation (using validate.js).
this enable to add new rules for this form in the pageValidation list.
*/
var collectvalidation = {fname:{presence: {message:\Required field missing: Please enter the First name}}, lname:{presence: {message:\Required field missing: Please enter the Last name}}};

edit notice it is only first backslash and not terminating.

sjpadgett · October 20, 2017, 6:41pm

I’m almost convinced this is php bug on windows and like I say the rules in list should be setup as if a string and enclosed in quotes (same as if a static array in code). I know you worry about Matrix but I would change and move on.

sjpadgett · October 20, 2017, 6:51pm

I reality I don’t understand why we have a static list for individual forms. In the end once they are set, they will never change and is why validation rule should be set up with the form they effect. I would pull those static json rules and stick them where they are called in the form.

brady.miller · October 20, 2017, 7:21pm

to clarify, if I go to Administration->Lists->Page Validation
then at row for user_admin#user_form, I have the following entry at Page Validation column:

{fname:{presence: {message:"Required field missing: Please enter the First name"}}, lname:{presence: {message:"Required field missing: Please enter the Last name"}}}

It sounds like this is different on windows and would then be an issue on the sql import (during install or upgrade) for these items.

brady.miller · October 20, 2017, 7:24pm

If this is the case, then perhaps we just need to escape the " here:

github.com

openemr/openemr/blob/master/sql/database.sql#L8236-L8250


INSERT INTO list_options (list_id, option_id, notes, title, activity, seq) VALUES ('race','konkow','1319-3','Konkow', '0',3960);
INSERT INTO list_options (list_id, option_id, notes, title, activity, seq) VALUES ('race','kootenai','1321-9','Kootenai', '0',3970);
INSERT INTO list_options (list_id, option_id, notes, title, activity, seq) VALUES ('race','korean','2040-4','Korean', '0',3980);
INSERT INTO list_options (list_id, option_id, notes, title, activity, seq) VALUES ('race','kosraean','2093-3','Kosraean', '0',3990);
INSERT INTO list_options (list_id, option_id, notes, title, activity, seq) VALUES ('race','kotlik','1926-5','Kotlik', '0',4000);
INSERT INTO list_options (list_id, option_id, notes, title, activity, seq) VALUES ('race','kotzebue','1867-1','Kotzebue', '0',4010);
INSERT INTO list_options (list_id, option_id, notes, title, activity, seq) VALUES ('race','koyuk','1868-9','Koyuk', '0',4020);
INSERT INTO list_options (list_id, option_id, notes, title, activity, seq) VALUES ('race','koyukuk','1776-4','Koyukuk', '0',4030);
INSERT INTO list_options (list_id, option_id, notes, title, activity, seq) VALUES ('race','kwethluk','1927-3','Kwethluk', '0',4040);
INSERT INTO list_options (list_id, option_id, notes, title, activity, seq) VALUES ('race','kwigillingok','1928-1','Kwigillingok', '0',4050);
INSERT INTO list_options (list_id, option_id, notes, title, activity, seq) VALUES ('race','kwiguk','1869-7','Kwiguk', '0',4060);
INSERT INTO list_options (list_id, option_id, notes, title, activity, seq) VALUES ('race','la_jolla','1332-6','La Jolla', '0',4070);
INSERT INTO list_options (list_id, option_id, notes, title, activity, seq) VALUES ('race','la_posta','1226-0','La Posta', '0',4080);
INSERT INTO list_options (list_id, option_id, notes, title, activity, seq) VALUES ('race','lac_courte_oreilles','1132-0','Lac Courte Oreilles', '0',4090);
INSERT INTO list_options (list_id, option_id, notes, title, activity, seq) VALUES ('race','lac_du_flambeau','1133-8','Lac du Flambeau', '0',4100);

sjpadgett · October 20, 2017, 8:08pm

Yep you hit it. My linux servers are okay too just didn’t think to look for dif in the lists. You don’t by any chance know when the list were added?

stephenwaite · October 20, 2017, 8:18pm

sjpadgett · October 20, 2017, 9:12pm

This goes back to 4.2.2-5.0.0 upgrade. I know i’ve used user edit dialog since then. Good grief, I hate mystery such as this…This has had to be here for awhile and just now showing. Let’s just ignore it 'till someone else finds it…Okay:)

brady.miller · October 20, 2017, 9:29pm

For now, will fix it in database.sql and upgrade script(and will ensure don’t have other unescaped quotes in database.sql). Since you are using php 7.1, kind of wonder if it may be from behavior of a newer mysql version (maybe why nobody has reported this).

brady.miller · October 20, 2017, 9:34pm

sigh,
Just realized this will also need to go out in a 5.0.0 patch along with package rebuilds…

sjpadgett · October 20, 2017, 9:37pm

Not if I delete this thread, ban everyone from using windows and just pretend this never happen:) Or, I could make absolutely sure this is not a fluke and upgrade on one of my other machine… I vote for option 1…