arnabnaha wrote on Saturday, March 26, 2011:
Hi Brady, Tony, Rod and others…
The official code has been released…but still the facility add screen is frozen. Add facility from the administration->Facilities still have a problem. It doesnt allows one to save a facility. This has been talked about in the trackers by tony a number of times. Please fix it in the official codebase…it should be stable and without errors!!!
Dr. Arnab Naha
mukoya wrote on Saturday, March 26, 2011:
Arnab is right. I can’t edit facility either. Windows 7 64 bit Xampp 1.7.3. Have not been noticing this because I have a backed up database that I immediately import after a fresh install will facilities and all.
Mukoya.
bradymiller wrote on Sunday, March 27, 2011:
hey,
As I recall, this has been quite a vexing bug, and I think with already several partial “fixes”.
Tested this on the online demo (Mandriva 2008 MySQL 5.0.45 PHP 5.2.4) and on my development server (Ubuntu 10.04 Server, php 5.3.2, mysql 5.1.41):
It works fine on Firefox and Explorer, but bug shows up on Chrome, Safari, and Opera.
Here are the bug trackers in the past related to this subject with more info:
http://sourceforge.net/tracker/?func=detail&aid=3225317&group_id=60081&atid=493001
http://sourceforge.net/tracker/?func=detail&aid=3095867&group_id=60081&atid=493001
http://sourceforge.net/tracker/?func=detail&aid=3056922&group_id=60081&atid=493001
http://sourceforge.net/tracker/?func=detail&aid=3032727&group_id=60081&atid=493001
here is forum discussion related to this:
http://sourceforge.net/projects/openemr/forums/forum/202506/topic/3767824
Should use Firefox for now, and can include a bug fix (when it exists) when release the next patch.
-brady
tmccormi wrote on Sunday, March 27, 2011:
The online demo does not work from using firefox from my Unbuntu client. However it ALL works fine when I install it on my Ubuntu servers and use ANY broswer….
This is vexing and so far no one has found “the” fix. MI-Squared will offer a $100 gift certificate to the first coder that can fix this for the 4 top browsers/OS mixes Firefox, IE, Chrome, Safari/Linux/Windows XP and 7/Mac
Community has to agree it fixed.
-Tony
bradymiller wrote on Sunday, March 27, 2011:
hi,
To be more specific on my testing above. All my browsers are run in Windows.:
Was able to add an edit facilities in Firefox(3.6.16) and Explorer(IE8) from both servers described above.
Was not able to add or edit a facility in Chrome(10), Safari,(4.04) or Opera from both server described above.
-brady
bradymiller wrote on Sunday, March 27, 2011:
Tony,
So that means that the same version on Firefox works when run on Windows, but not when on Ubuntu. Odd.
-brady
bradymiller wrote on Sunday, March 27, 2011:
Tony,
Before your bank is broken, see if the patch(es) here help out some:
http://sourceforge.net/tracker/?func=detail&aid=3056922&group_id=60081&atid=493001
-brady
tmccormi wrote on Sunday, March 27, 2011:
I tried those patches a while back and they did not change the behavior, I’ll be traveling all day tomorrow, no net access at all. Since it works in my installed stuff there is no way to test if anything fixes it… So … someone that has the error on their own system (s) has to fix it … :-) I’d be happy to pay-up on this one!
-Tony
arnabnaha wrote on Sunday, March 27, 2011:
Hi Brady….
I am using windows 7 32 bit….and firefox 3.6.16 but i am unable to add or edit the facilities….please help…
Dr. Arnab Naha
bradymiller wrote on Sunday, March 27, 2011:
Placed a fix for this on github (derived from the master branch):
https://github.com/bradymiller/openemr/commits/facility-fix
This was an interesting bug. The modal was calling a reload on the parent (the facility listing), while submitting the form (which happens to also be the same script as the facility listing) at the same time in the modal itself. Javascript doesn’t wait around for things to finish, so a fast server/browser is probably what masks the bug (perhaps firefox and IE also make javascript wait a little). The fix was to simply remove the javascript stuff and submit the form through the _parent target.
Arnabnaha.
After the fix is confirmed to work across all browsers/Os’s we can then issue it in the form of a patch(like the previous 3.2.0 patches) which are easy to install.
-brady
arnabnaha wrote on Sunday, March 27, 2011:
Thanks Brady…
Will be testing the fix right now…and update about windows and firefox…
arnabnaha wrote on Sunday, March 27, 2011:
Its working absolutely fine on Windows 7, 32 bit, firefox 3.6.16, firefox 4 beta, IE8 browsers. Also working great on Windows XP (all the browsers mentioned above). Thank you brady…u r a genius….!!!
mukoya wrote on Sunday, March 27, 2011:
Great work Brady on the Facility add/edit bug. Yet to test, will post back.
One other thing, I am not an expert in software development but I hear that once a release is out, all other improvements must come as patches etc. Is it possible to break this rule on this particular one? Can we incorporate this bug fix in the main codebase of 4.0. One of the very first things someone interested in OEMR is going to do after install is to add a facility. If he cant add, and has to look for a patch (that he may not even know exists) it will be a big minus.
What about at least incorporating it in the Xampp and appliance releases?
Mukoya.
mukoya wrote on Sunday, March 27, 2011:
If incorporation is not possible, then lets make it very clear that a new installation will need this patch. We can include this information plus a link to the file in the Installation guide/wizard
mukoya wrote on Sunday, March 27, 2011:
This fix is working well on windows 7 64 bit with xampp 1.7.3. chrome, opera, firefox. Able to edit/add facility.
However i guess firefox is the best browser to run openemr as there are minor UI issues with both chrome and opera involving display of calender and navigation menu.
mukoya.
tmccormi wrote on Sunday, March 27, 2011:
Since it works on all my local installs and it appears to be working where used to be broken, I suggest that we delivery it to the 4.0-dev master and test it on the public demo. If that passes then Brady get’s the $100 bounty 
Great work!
-Tony
ajperezcrespo wrote on Sunday, March 27, 2011:
Confirmed.
Tested on Firefox 4, IE8, and Chrome 10.
Works on all 3.
Add and Edit just fine.
Thanks Brady.
Alfonso
bradymiller wrote on Monday, March 28, 2011:
Committed fix to master and rel-400 branches today.
mukoya,
The fix will go out in a patch. Will plan to place instructions in the installation/upgrade instructions to install the patch as the last step (and will plan to incorporate latest patch in the Appliance and XAMPP releases).
-brady
infotech303 wrote on Sunday, April 17, 2011:
Hello
We seem to be having the same issue as listed in this thread.
We cannot add or edit a facility.
We have the following configurations and setup:
Windows Server 2008 R2
IIS7
PHP 5.3.5
MySQL -5.1.54-community
OpenEMR 4.0.0
Patch Set 4-0-0-Patch-2
We loaded the base software (4.0.0), then the patch set(4-0-0-PATCH-2), then let the software create the database schema. The current test system has
IUSR set to full control on the total directory structure to remove the posibility of a permissions issue.
We have the following settings in the PHP.INI file:
short_open_tag = On
display_errors = Off - currently - ON to help dianose this issue
register_globals = Off
magic_quotes_gpc = On
max_execution_time = set to at least 60, - Ours is at 300
max_input_time = 90
memory_limit = 128M
We have restarted the IIS server and the MySQL Database, then……
We are able to login to the software, but cannot configure it. We try to set the facility first and get the below errors.
First Error on Login:
Warning: error_log(): It is not safe to rely on the system’s timezone settings. You are *required* to use the date.timezone setting or the
date_default_timezone_set() function. In case you used any of those methods and you are still getting this warning, you most likely misspelled the
timezone identifier. We selected ‘America/Denver’ for ‘-6.0/DST’ instead in C:\inetpub\wwwroot\emr\emr\interface\globals.php on line 134
Error Message in php-errors
Session site ID has been set to ‘default’
Error Message in upper screen when trying to modify the default facility:
ERROR: query failed: update facility set name=‘test’, phone=‘000-000-0000’, fax=‘000-000-0000’, street=’’, city=’’, state=’’, postal_code=’’,
country_code=’’, federal_ein=’’, service_location=‘1’, billing_location=’’, accepts_assignment=’’, pos_code=‘01’, domain_identifier=’’, facility_npi=’’,
attn=’’ , tax_id_type=‘EI’ where id=‘3’
PLEASE HELP ASAP!!
Thanks,
Bill
IT@LCS.BZ
firmanet wrote on Wednesday, September 07, 2011:
This bug still exists. I tried with Explorer as well as Firefox and could not create or modify facility. It does work in the online demo. Any plans to get it fixed.