Unused User Admin Code?

OpenEMR Development
1

yehster wrote on Thursday, April 18, 2013:

Brady, Rod, and Tony,
Do any of you remember this commit from 2010?


I believe that what happened here is a big block of code was copied and pasted from user_admin.php into usergroup_admin.php. It probably should have been removed from user_admin.php at that time, but it wasn’t.

The whole block in user_admin.php for GET[‘mode’] = “update” is no longer used as everything is handled by usergroup_admin.php now. I’d like to remove it now. The “save” button still works without that big block of code in user_admin.php.

Let me know what you guys think.

Thanks…

2

julialongtin wrote on Thursday, April 18, 2013:

Kevin,

We’ve actually got patches to do that here, but have yet to separate them
out of our tree. We have also changed the resulting pages to using

s
instead of tables.

I’ve got about 19,000 lines of diff i’m working on breaking apart into
smaller more useful chunks, at
https://gitorious.org/~juri/openemr/juris-openemr .

Speaking of, Brady, I have more commits in the staging branch, for you to
merge.

Julia Longtin

On Thu, Apr 18, 2013 at 3:06 AM, Kevin Yeh yehster@users.sf.net wrote:

Brady, Rod, and Tony,
Do any of you remember this commit from 2010?

Users Admin UI cleanup (list, add, edit) · openemr/openemr@c2228f3 · GitHub
I believe that what happened here is a big block of code was copied and
pasted from user_admin.php into usergroup_admin.php. It probably should
have been removed from user_admin.php at that time, but it wasn’t.

The whole block in user_admin.php for GET[‘mode’] = “update” is no longer
used as everything is handled by usergroup_admin.php now. I’d like to
remove it now. The “save” button still works without that big block of code
in user_admin.php.

Let me know what you guys think.
Thanks…

Unused User Admin Code?https://sourceforge.net/p/openemr/discussion/202506/thread/80b0399d/?limit=25#c838

Sent from sourceforge.net because you indicated interest in
OpenEMR / Discussion / Developers

To unsubscribe from further messages, please visit
SourceForge.net: Log In to SourceForge.net

3

sunsetsystems wrote on Thursday, April 18, 2013:

Yeah if it’s unused code, for sure get rid of it. Thanks.

Rod
http://www.sunsetsystems.com/

4

bradymiller wrote on Thursday, April 18, 2013:

Hi,

I don’t remember that code, but agree that if not used, then remove it.

On unrelated note, I just merged in Julia’s commits. After I merged it in I realized I missed some code on my review that seems to bring in a modul to the address book listing script. However, a modul isn’t being used there on testing(a popup is instead). Can I get some clarification on that code Julia?

thanks,
-brady
OpenEMR

5

yehster wrote on Thursday, April 18, 2013:

Julia,
Can you help me out by pointing me towards a specific commit that confirms my hypothesis about redundant code in these two files?
Thanks,
-Kevin