mdsupport wrote on Wednesday, June 29, 2011:
Sharing tweak for main_title.php. Changes include:
1. Link to Hide/Show the navigation menu.
2. Regroup the title area into 4 sections using 2 rows each.
Hiding the navigation menu on small (10in to 12in) screens of tablet devices such as iPad gives significantly more viewing area. Devices with 7in screens will need complete redesign of the interface.
tmccormi wrote on Wednesday, June 29, 2011:
I’ve been wanting that! I’ll check it out this evening. Awesome.
-Tony
bradymiller wrote on Thursday, June 30, 2011:
hi,
Pretty cool. Placed review on github.
-brady
mdsupport wrote on Thursday, June 30, 2011:
Will post the update by next week after the current roll out.
mdsupport wrote on Tuesday, July 05, 2011:
Revised Main_title incorporating the comments. Please review.
bradymiller wrote on Wednesday, July 06, 2011:
hi,
Looks and tests nicely, so committed to sourceforge (note I rebased your two commits into one). Thanks for the contribution.
-brady
ajperezcrespo wrote on Wednesday, July 06, 2011:
Hi,
Looks Great and works great on FireFox 5.
Slightly off on IE 8 and Chrome 12
It works Great but the Hide Menu option is half hidden and takes a little maneuvering to click it just right.
Does wonders for smaller screens. Great addition
Thanks!
mdsupport wrote on Wednesday, July 06, 2011:
I see the problem in IE caused because I tried to minimize changes to the HTML. ‘Slightly off’ is very charitable way to describe the result in IE. More reliable rendering will be with two rows instead of using <BR> tag. I will submit an update shortly. Let me know if there are any other ideas. Thx.
mdsupport wrote on Thursday, July 07, 2011:
Tried to fix display in non-Firefox browsers. There are still some differences in spacing but the links are no longer hidden. Please review and suggest if there is a better way…
Thx.
bradymiller wrote on Friday, July 08, 2011:
Hi,
Layout looks good, but several suggestions (mostly related to being confused about what the links are):
1. Have anything that is a link blue (ie. Hide Menu, Home, Manual).
2. Make the Logout button like the New Patient Button.
3. Remove the link formatting from the Logged in stuff (simply use span instead (title should still show up i think).
4. The Home and Manual are not lining up (guessing related to btnrigh; probably best to not do this and instead use style of the TD with the button to make a left-margin there. I think I know the issue you’re likely having with the button (ie. it floats to the left; see how I controlled this issue in code at top of the patient summary screen(ie. the Delete button).
-brady
mdsupport wrote on Saturday, July 09, 2011:
Pushed the fixes for formatting issues.
Noticed the issue with Home, Manual links moving depending on the length of the user’s name. Dropped the ‘Logged in:’ label to reduce footprint. Hope that works.
Please review. Thx.
bradymiller wrote on Tuesday, July 12, 2011:
Hi,
Make some minor mods and committed your changes to sourceforge. My minor mods were following:
Moved the class=text from a to td tags (for Home and Manual links since these weren’t showing up as blue until I did this).
Changed LOG OUT back to Logout (like to avoid changing labels, because it then creates a new term that needs to go through translation. Note erroneous/incorrect/confusing labels should still be fixed, just don’t think that is the case here. Of course, if you disagree, always open to discussion).
-brady