Service Note, generic date above every time

Helptechs · May 2, 2024, 4:51pm

Situation
When I print service notes a generic date appears above every service note post upgrade to 7.0.2

OpenEMR Version
I’m using OpenEMR version 7.0.2

Browser:
I’m using: Chrome and Edge

Operating System
I’m using: Windows 10 - 11

Search
Did you search the forum for similar questions?

Logs
Did you check the logs? yes
Was there anything pertinent in them? No
Please paste them here (surround with three backticks (```) for readability.
You can also turn on User Debugging under Administration->Globals->Logging User Debugging Options=>All

stephenwaite · May 2, 2024, 6:32pm

hi @Helptechs , can you reproduce on the main demos?

Links
Demo Link
OpenEMR 7.0.2 Main Demo https://demo.openemr.io/openemr
Alternate Demo https://demo.openemr.io/a/openemr
Another Alternate Demo https://demo.openemr.io/b/openemr

Helptechs · May 2, 2024, 6:35pm

What is the login credentials for the main demo link

Helptechs · May 2, 2024, 8:10pm

The date (12/31/1969) did not appear on every service note until after the upgrade to 7.0.2

Helptechs · May 2, 2024, 8:40pm

I can’t reproduce on the main demo - because there is no data or option for generate service note

stephenwaite · May 2, 2024, 11:22pm

can you get to Phil’s Report menu on the dashboard?

Helptechs · May 3, 2024, 6:06pm

Yes, this issue is that this date pop’s up on every service note post upgrade to 7.0.2

juggernautsei · May 8, 2024, 10:16pm

Hi,
did you ever figure out what was causing this issue? I suspect it is a data issue not a code issue.
There are no errors of any kind being thrown in the system.

sjpadgett · May 8, 2024, 10:31pm

Sherwin,
This will be hard coded somewhere I suspect in layout options.
I’d search repo history for any commits in options.
I’m really busy but if I get a quick minute, i’ll track it down.

juggernautsei · May 9, 2024, 1:48am

@sjpadgett it is a data issue. I was able to make it go away by checking for an empty date.
Wrap line 787 in an if statement.

github.com

openemr/openemr/blob/6cef758e9648672979daaa9dbd588a413e4408a2/interface/patient_file/report/custom_report.php#L787

      
        
            
            
if ($res[1] == 'newpatient') {
                echo "<div class='text encounter'>\n";
                echo "<h4>" . xlt($formres["form_name"]) . "</h4>";
            } else {
                echo "<div class='text encounter_form'>";
                echo "<h4>" . text(xl_form_title($formres["form_name"])) . "</h4>";
            }
            
            
// show the encounter's date
            echo "(" . text(oeFormatSDFT(strtotime($dateres["date"]))) . ") ";
            if ($res[1] == 'newpatient') {
                // display the provider info
                echo ' ' . xlt('Provider') . ': ' . text(getProviderName(getProviderIdOfEncounter($form_encounter)));
            }
            
            
echo "<br />\n";
            
            
// call the report function for the form
            ?>
            <div name="search_div" id="search_div_<?php echo attr($form_id) ?>_<?php echo attr($res[1]) ?>" class="report_search_div class_<?php echo attr($res[1]); ?>">

Wrap it like this to patch the issue.

// show the encounter's date
if (!empty($dateres["date"])) {
          echo "(" . text(oeFormatSDFT(strtotime($dateres["date"]))) . ") ";
  }

It treats the symptom but not the root issue.

There is a 0 being passed into this function from the

function getEncounterDateByEncounter($encounter)
{ 
    global $attendant_type;
    $table = $attendant_type == 'pid' ? 'form_encounter' : 'form_groups_encounter';
    // $sql = "select date from forms where encounter='$encounter' order by date";
    $sql = "SELECT date FROM " . escape_table_name($table) . " WHERE encounter = ? ORDER BY date";
    return sqlQuery($sql, array($encounter));
}

It will take some time to get down to the root of the sqlQuery that is not filtering out the empty encounter.

sjpadgett · May 9, 2024, 3:45am

nice troubleshooting Sherwin but it’s still a code issue not database. Spitting hairs still a good catch.
I didn’t read issue to see that its in custom report. I was thinking layouts.

juggernautsei · May 9, 2024, 10:23am

@sjpadgett I have to agree it is a code issue. I have spent time going over the data and can’t find a newpatient encounter with no encounter number. I don’t know if I should spend any more time tracking down the bug since the behavior produced by the bug has been mitigated. This should be good enough for now. I will open a PR today.

Helptechs · May 13, 2024, 6:11pm

Thanks Sherwin, please keep me updated on the pull request!. And when you get time to get down to the root of the sqlQuery that is not filtering out the empty encounter.