PHP7 clean up

OpenEMR Development
1

bradymiller wrote on Friday, June 03, 2016:

Hi,

For any developers whom are working in php7 and want straightforward bug fixes to work on, here are a couple warnings/deprecated php7 issues that I noted when I was testing the forms:

[03-Jun-2016 03:44:22 America/Los_Angeles] PHP Warning: Declaration of C_FormVitals::default_action($form_id) should be compatible with Controller::default_action() in /var/www/openemr/interface/forms/vitals/C_FormVitals.class.php on line 8

[03-Jun-2016 03:46:21 America/Los_Angeles] PHP Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP; FormPainMap has a deprecated constructor in /var/www/openemr/interface/forms/painmap/FormPainMap.php on line 21

[03-Jun-2016 03:46:21 America/Los_Angeles] PHP Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP; AbstractClickmapModel has a deprecated constructor in /var/www/openemr/interface/clickmap/AbstractClickmapModel.php on line 31

[03-Jun-2016 03:46:45 America/Los_Angeles] PHP Warning: API violation: set function called with empty or non numeric string. in /var/www/openemr/interface/clickmap/AbstractClickmapModel.php on line 157

[03-Jun-2016 03:47:13 America/Los_Angeles] PHP Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP; FormPriorAuth has a deprecated constructor in /var/www/openemr/interface/forms/prior_auth/FormPriorAuth.class.php on line 11

-brady
OpenEMR

2

juggernautsei wrote on Thursday, August 11, 2016:

I have just run into these issues and I am working trying to solve them. I’ll let you know if I get anywhere with
[03-Jun-2016 03:44:22 America/Los_Angeles] PHP Warning: Declaration of C_FormVitals::default_action($form_id) should be compatible with Controller::default_action() in /var/www/openemr/interface/forms/vitals/C_FormVitals.class.php on line 8

BTW, the system is throwing a zend_mm_heap error and a bunch of restarts.

3

juggernautsei wrote on Thursday, August 11, 2016:

did not work yet just changed the method not fixed the problem even though the error has gone away.

4

juggernautsei wrote on Monday, September 12, 2016:

5

juggernautsei wrote on Sunday, October 23, 2016:

Need help with this one:
On the fee sheet

[24-Oct-2016 02:42:00 UTC] PHP Stack trace:
[24-Oct-2016 02:42:00 UTC] PHP Notice: Undefined index: newcodes in C:\emr_wamp\www\openemr\interface\forms\fee_sheet\new.php on line 1226

I can see line 885 is

Lines 1224 - 1226
// If new billing code(s) were ed, add their line(s) here.
//
if ($_POST[‘newcodes’]) {

But newcode can’t be selected because it is hidden and the value is empty. Am I reading that right?