New fees not populating review on FeeSheet

juggernautsei · July 24, 2019, 3:25pm

The situation is that prices change. But the billing review pulls the fees from the billing table. So, when a provider changes the fees in the system. The review is showing the old charges and not the new charges.

@brady
@robert.down
@Matthew_Vita
@visolveemr
@growlingflea
@robertovasquez

Are there any students we can get to help with fixing this issue? Calling developers

stephenwaite · July 24, 2019, 8:41pm

hi @juggernautsei, when the fees are changed at Admin->Codes they are only for new charges to be added in the future. If understanding your situation correctly then wouldn’t want this to change charges already entered in the fee sheet right?

juggernautsei · July 24, 2019, 9:59pm

I am going through the fee sheet review code now.
First yes, don’t want to change the values in the billing table. That would mess up a whole lot of stuff.

But what needs to happen is that in the review, I am trying to figure out where is it getting the fees from. It can’t be the fee table so the information has to be coming from the billing table. In the fee_sheet_queries.php, the billing table is the only table addressed. See below.

github.com

openemr/openemr/blob/053f6e3939f8f9ba49cc19ef154654ffcd8326fc/interface/forms/fee_sheet/review/fee_sheet_queries.php#L289


/**
* retrieve the entries for the specified encounter's fee sheet
*
*
* @param int   $pid             the ID of the patient
* @param int   $encounter       the encounter ID
* @param array &$diagnoses      return by reference of all the diagnoses
* @param array &$procedures     return by reference of all the procedures
*
*/
function fee_sheet_items($pid, $encounter, &$diagnoses, &$procedures)
{
   $param=array($encounter);
   $sql="SELECT code,code_type,code_text,fee,modifier,justify,units,ct_diag,ct_fee,ct_mod "
         ." FROM billing, code_types as ct "
         ." WHERE encounter=? AND billing.activity>0 AND ct.ct_key=billing.code_type "
         ." ORDER BY id";
   $results=sqlStatement($sql, $param);
   while ($res=sqlFetchArray($results)) {
       $code=$res['code'];
       $code_type=$res['code_type'];

What would be a nice addon here is to check that the price has not changed. L313 is where this needs to happen in my opinion.

I was thinking of creating a function to check the value of the fee to see if has changed from the original.
This should populate the fee sheet with the correct value not solely depending on what is in the billing table.

function checkFee($code,$fee){
      $currentPrice = sqlQuery ("SELECT codes.id, prices.pr_price FROM `codes` LEFT JOIN prices ON prices.pr_id = codes.id WHERE codes.code = ?", array($code));

      if($currentPrice != $fee){
          return $currentPrice; 
        } else {
         return $fee;
       }
   }

I am thinking this should fix the issue and make sure that the most current fee is returned in the review.

Your thoughts please
@stephenwaite
@ken

I ended up taking a slightly different approach.

sjpadgett · July 25, 2019, 2:19pm

@juggernautsei This is worrisome too me. Maybe i’m missing a point so bare with me.

Where is this review?
Are you talking about an existing feesheet or is there a report i’m unaware?

stephenwaite · July 25, 2019, 2:25pm

hi @sjpadgett, it’s the review button that could be pretty useful, thanks @juggernautsei

had to click on @zbig01 nice help ? to see what the purpose was but will basically allow you to select previous cpts you’ve billed for from past encounters

sjpadgett · July 25, 2019, 2:31pm

ah of course, thanks…

juggernautsei · July 25, 2019, 2:34pm

The issue arose that there was a change in the prices/fees.
The review button is in the fee sheet.

After selecting the review button, you can select any visit in the past to populate the fee sheet with.

In the code the fees that are brought into the visit are from the billing table and not from the price table. So, when there is a change in prices/fees. The old fee will always be selected causing the doctors to have to keep changing the fees.

This is a simple check of the fee/price to see if it has changed. If it is changed use the price it changed to instead of the price in the billing table.

That is all it needs to do at this time. I didn’t do elegant this time. I just hacked it in there. We can work on a more elegant solution now.

sjpadgett · July 25, 2019, 2:58pm

Thanks for clarification and sorry to make ya type it out. Good idea with only suggestion that comes to mind is maybe change price color to red in review if different from feesheet. ie could add a bg-danger class or color style via javascript to field. Certainly not needed though.