stephen-smith wrote on Monday, January 24, 2011:
Patch Tracker Item
Git branch @ Gitorious
PHP’s lint mode (php -l) detected a syntax error in this file. It always defines a class with the same name as a class in one of the files it includes/requires. This patch renames the class in this file so that it no longer conflicts.
Based on my understanding, the class renamed by this patch couldn’t have been explicitly used anywhere except in the body of the class itself. So, this patch doesn’t change any uses of the “soapclient” name outside of the class. However, I have yet to find a reference I trust that says exactly what PHP does when it encounters this error when not in lint mode.
In any case, some searching through the source code indicates we may not even use the renamed class. I’ll merge into master and push to our central repository in 72 hours unless I get a complaint.
PHP’s lint mode also reports an error with gacl.ini.php, but that’s because it is not really a PHP file and the error is intentional. This patch doesn’t attempt to fix that issue, but I may work on that in the future.