Minor Bug Fixes (assorted)

tmccormi wrote on Monday, January 24, 2011:

see: https://github.com/tmccormi/openemr/commit/d227fc7ec54a99acedff13dcaf43f043f7b669d8

add icd9 and minor fixes to the following:
add_edit_event.php - spelling chg and add xl()
main_screen.php - correct placement of head tag
deleter.php - correct closing tag on cancel button
demographics.php - fix width of second column div to 300px and some other cleanup
add_transaction.php - fix location of close form tag
style_default.css - fix width of second column div to 300px
gen_x12_837.inc.php - POS formatting to avoid stripping the leading zero
sql/icd9-codes-insert.sql - add to distro
sql/icd9-codes-replace.sql - add to distro

These are contributions from various development sources …
Will commit then late tonight unless I hear otherwise
-Tony

sunsetsystems wrote on Monday, January 24, 2011:

Maybe this commit is not the time, but it’s better to express column widths (and dimensions in general) as percentages rather than as pixels, where that is possible.

Rod
www.sunsetsystems.com

tmccormi wrote on Tuesday, January 25, 2011:

Actually I agree with that but the left div was already set hard at 655px so I used that model.  I can change it to something like 66% and 33% and test that.  It would make me feel better about this piece of code as well.
-Tony

tmccormi wrote on Tuesday, January 25, 2011:

This has been done.  I did change the style sheet to use percentages for the tabbed area widths and background display widths

commit 388b50011f662c1f870ddab669f31be8810b33a4
Author: tmccormi <tony@mi-squared.com>
Date:   Tue Jan 11 13:31:38 2011 -0800

    Add icd9 and minor fixes to the following:
    add_edit_event.php - spelling chg and add xl()
    main_screen.php - correct placement of head tag
    deleter.php - correct closing tag on cancel button
    demographics.php - fix width of second column div background
    add_transaction.php - fix location of close form tag
    style_default.css - fix widths tabbed column divs and backgounds to percentages
    gen_x12_837.inc.php - POS formatting to avoid stripping the leading zero
    sql/icd9-codes-insert.sql - add to distro
    sql/icd9-codes-replace.sql - add to distro
   
    Signed-off-by: tmccormi <tony@mi-squared.com>

interface/main/calendar/add_edit_event.php
interface/main/main_screen.php
interface/patient_file/deleter.php
interface/patient_file/summary/demographics.php
interface/patient_file/transaction/add_transaction.php
interface/themes/style_default.css
library/gen_x12_837.inc.php
sql/icd9-codes-insert.sql
sql/icd9-codes-replace.sql

sunsetsystems wrote on Tuesday, January 25, 2011:

Thanks Tony!  Kinda looks like the fixed widths are still there, though?  Maybe I’m looking at the wrong thing.

Rod
www.sunsetsystems.com

tmccormi wrote on Tuesday, January 25, 2011:

It’s a confusing mix of both, all I was working on was the background shading widths so the right column would not be the same width as the left column. Just in div.tabContainer widths and the div.notab and notab-right widths. 

We need a real CSS stylist to go though it all for best use models …

-Tony

aethelwulffe wrote on Wednesday, January 26, 2011:

While I am really busy trying to get a boat underway for Bimini, I still have taken a bit of time to test the latest commits to the master.  I have gone down Tony’s list here, and tried some other stuff like the billing module.  While I have not turned magic quotes back on to check that, it still seems like all this stuff is clean.  Billing searches seem to all work (with cursory experimentation).  Good update dudes! 
  While I agree about using percentages whenever practical, I have also tried things out on a a variety of resolutions and proportions.  For whatever it is worth, while it does not always use up every last bit of white space on larger widescreens, it is still pretty darn good even on netpad 9" screen.

tmccormi wrote on Wednesday, January 26, 2011:

Thanks for the feedback, it’s really good to hear from the users on things like this.
-Tony