michaelf5 wrote on Friday, May 14, 2010:
Added a patch for review that shows an initial display of a CCR / CCD
michaelf5 wrote on Friday, May 14, 2010:
URL: https://sourceforge.net/tracker/?func=detail&atid=1245239&aid=3001790&group_id=60081
bradymiller wrote on Saturday, May 15, 2010:
hey,
TESTING REVIEW:
Tried again and freezes when click the ‘View CCD’ and ‘View CCR’ buttons. You’ve hard-coded your database in all the functions in ccr/sql/ccr_sql.inc which is causing the freezing. If i change these all to my database, then get blank screen when hit ‘View CCD’ and ‘View CCR’ buttons.
Here is log with ‘View CCD’ button:
PHP Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /var/www/html/openemr/ccr/createCCRResult.php on line 32, referer: http://192.168.1.146/openemr/interface/patient_file/report/patient_report.php
PHP Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /var/www/html/openemr/ccr/createCCRResult.php on line 192, referer: http://192.168.1.146/openemr/interface/patient_file/report/patient_report.php
PHP Warning: DOMDocument::save(generatedXml/ccrForCCD.xml) : failed to open stream: No such file or directory in /var/www/html/openemr/ccr/createCCR.php on line 197, referer: http://192.168.1.146/openemr/interface/patient_file/report/patient_report.php
PHP Fatal error: Class ‘XSLTProcessor’ not found in /var/www/html/openemr/ccr/createCCR.php on line 207, referer: http://192.168.1.146/openemr/interface/patient_file/report/patient_report.php
Here is log with ‘View CCR’ button:
PHP Warning mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /var/www/html/openemr/ccr/createCCRResult.php on line 32, referer: http://192.168.1.146/openemr/interface/patient_file/report/patient_report.php
PHP Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /var/www/html/openemr/ccr/createCCRResult.php on line 192, referer: http://192.168.1.146/openemr/interface/patient_file/report/patient_report.php
PHP Fatal error: Class ‘XSLTProcessor’ not found in /var/www/html/openemr/ccr/createCCR.php on line 181, referer: http://192.168.1.146/openemr/interface/patient_file/report/patient_report.php
here is list of my php modules:
ctype
date
dom
filter
ftp
gd
gettext
hash
json
libxml
mbstring
mysql
openssl
pcre
pgsql
posix
Reflection
session
SimpleXML
SPL
standard
sysvsem
sysvshm
timezonedb
tokenizer
xml
xmlreader
xmlrpc
xmlwriter
xsl
zip
zlib
CODING REVIEW:
openemr/ccr/sql/ccr_sql.inc:
–don’t hardcode the multiple database settings. Why not make it a variable , so easy to change them all with one edit? Also, to integrate into OpenEMR, then rec. bringing in interface/globals.php, and then using the sql functions in library/sql.inc .
openemr/interface/patient_file/report/patient_report.php
–don’t put trailing or ending whitespace in the xl() functions (ie the ’ View CCD ’ should be ‘View CCD’). If want whitespace, then add it outside the function.
I’d have more to add if can get it to actually work.
-brady
michaelf5 wrote on Tuesday, May 18, 2010:
Updated patch available that uses SQL functions from sql.inc
bradymiller wrote on Wednesday, May 19, 2010:
hey,
-the ankle form is not installed by default (it breaks if this table does not exist)
After installing the ankle form it works, but obviously some more work today before the reports are comprehensive. Where is the next phase of this project headed? What are your thoughts on internationalization (ie. translation) of these forms?
CODING REVIEW:
—interface/globals.php brings in library/sql.inc automatically, so don’t have to explicitly include it (but not a big deal to include them both)
—the $con line is not needed (this stuff is already done in sql.inc script), rec. removing these lines.
—where are all these echos going???
-brady
johnbwilliams wrote on Wednesday, June 02, 2010:
The next phase of this project, which will come after 2011 certification, is to add to and improve the coded content of the CCR to the level needed to generate a CCD Level 3. At this time we have not contemplating internationalization of these reports.
bradymiller wrote on Wednesday, June 02, 2010:
hey,
I realized these are just generic reports anyways. Are these reports GPL’d?
-brady