Major CVS update from April 1, 2008

OpenEMR Development
1

drbosman wrote on Monday, March 24, 2008:

The Dutch OpenEMR group will do a major update to the CVS. We will incorporate our DBC and Vektis (Dutch billing system) code into CVS.
This will require us to download a snapshot of the CVS; incorporate our code into the snapshop; test to make sure our code will work as expected without breaking current code; then update the CVS.
This process will take between 2 and 4 weeks.

We therefore kindly request the following:

* We will take a snapshot of the CVS on April 1, 2008.
* Our update will take 2 to 4 weeks
* During that time, please do NOT add significant changes to the CVS
* If you do have to make (preferably minor) changes, please post a short note as a follow up message in this thread so we can make sure these changes will not be overwritten when we update the CVS with our new code
* When we are done we will post a follow up to this message

Thank you very much for your cooperation.

2

cfapress wrote on Monday, March 24, 2008:

I too have been doing some big changes in the CVS code. I’ve been trickling them to Rod over the past few weeks. My changes have mainly revolved around the calendar and basic user interface. Nothing structural and certainly nothing related to billing.

Are your changes strictly in the billing area?

If not, where else?

Jason

3

sunsetsystems wrote on Monday, March 24, 2008:

Dr. Bosman, thanks for the warning.  I’ll plan to check in Jason’s more recent changes before you start, and some of my own.  Agreed that it would be good to get some more info as to the areas of the code that you’ll be changing.

Note that CVS will warn you of conflicting changes when you do a checkin and in many cases will resolve concurrent changes to the same module.  So if it is used correctly then overwritten changes should never happen, and you should make sure your team knows how to do that.  Of course we’ll want to stay out of your way to make things as easy as possible for your group.

Thanks,

Rod
www.sunsetsystems.com

4

drbosman wrote on Monday, March 24, 2008:

We wrote our modules from scratch. We do not use the original billing module. A partial list of modifications is here: http://sourceforge.net/forum/message.php?msg_id=4656421
The reason we ask not to make structural changes to CVS is we have been modifying parts of OpenEMR to make it work with our code. We will update CVS and make sure that our code does not break the "original" OpenEMR. Any conflicting changes made after April 1 will require us to restart the testing phase which would extend our update process.

5

sunsetsystems wrote on Tuesday, March 25, 2008:

Hmm, as I think about this I’m wondering if we need to make a branch for you.  I have some very active clients right now and 4 weeks is a long time to hold on to changes.  Looking at other threads in this forum, I have a feeling other developers will also be wanting to make commits.

The branch could be merged back into the trunk when you are done.

Comments?

Rod

6

drbosman wrote on Monday, April 07, 2008:

Update and explanation:
- our system is kept as much as possible away from the original code (we have around 18 common files only)
- the modifications in common files are well commented and try to interfere as little as possible with the rest of the code
- the original tables are not altered; we are using only new tables.
- we don’t need a waiting time from others committing to CVS; we’ll be committing as other developers do.

7

drbowen wrote on Monday, April 07, 2008:

Dear Michiel,

The new tables shouldn’t cause any problems.  If there are 18 common files, feeding then in one by one would seem to cause the least disruption and hopefully make debugging easier.

Let me know and I will try to help test.

Sincerely,

Sam Bowen, MD

8

drbowen wrote on Monday, April 07, 2008:

Dear Michiel,

Could you post a list of the files that will need to be merged here so that we can hopefully know what is most likely to be affected by the changes?

Sam Bowen
http://www.oemr.org/ 

9

lemonsoftwarero wrote on Tuesday, April 08, 2008:

Here is the required list with some small comments:

library/

patient.inc
new functions inserted (getPatientDataNL; getFacilities)
modified newPatientData() function -> new args ($nstreet, $nnr, $nadd, $prefixlast, $prefixlastpartner, $lastpartner)
new sql statements who deal with new args

interface/patient_file/encounter/

coding.php
implement specific DBC links: Add DSM-IV, etc…

encounter_bottom.php
implement some specific menu items (Content; DBC History)

patient_encounter.php
- used instead of encounter_bottom in ‘non concurrent’ view version

interface/patient_file/summary/

demographics.php

demographics_full.php
addresses in dutch format
names in dutch format
care provider & referer new fields

demographics_save.php
modified patient date (added addresses, names and other infos – dutch specific)
call newPatientData() with new infos

summary_title.php
display dutch name format (with prefixes and partners)

encounter_title.php
display dutch name format (with prefixes and partners)

/interface/usergroup/

user_admin.php
add job description dropdown for DBC

usergroup_admin.php
add job description dropdown for DBC

usergroup_navigation.php
add menu entries for DBC/Vektis 

facility_admin.php
facilities updating statement (cl_facility_circuit)

interface/new

new_patient_save.php
new.php
– replace middle name with dutch prefix for names (van den, van, etc)

interface/

globals.php – DBC switch ($GLOBALS[‘dutchpc’])

interface/main/calendar

add_edit_events.php
activities dropdowns

library/

translation.inc.php
mb_strpad – custom function for multibyte string padding

10

drbosman wrote on Wednesday, April 16, 2008:

We have finished our integration into CVS.

One word of advice: never mention you need a week of little CVS activity, because activity has never been as high as during the last two weeks :slight_smile:

Great to see that so many people are actively contributing to OpenEMR!

Some words in Dutch to explain what we did:

OpenEMR is een open-source electronisch medisch dossier. Het is nu mogelijk om ambulante (poliklinische) diagnose behandelcombinaties (DBC) te openen voor GGZ (geestelijke gezondheidszorg) in OpenEMR, en daarna bestanden volgens Vektis-standaard GZ311 aan te leveren aan Vecozo (of bijvoorbeeld Fa-med) en DBC-bestanden volgens de geldende specificaties aan Disportal.

Email voor meer informatie: drbosman apestaart users punt sourceforge punt net

11

drbowen wrote on Wednesday, April 16, 2008:

Congratulations!

Thank you Dr. Bosman, Cristian and your group for this big effort.  It is much appreciated by all.

Sam Bowen, MD

12

sunsetsystems wrote on Wednesday, April 16, 2008:

Thanks Dr. Bosman!  Sorry for all the activity recently!  Your group must be commended for working around it all.

However I did find two cases where recent changes were overwritten and lost:

(1) interface/new/new.php appears to be a modification of version 1.11 instead of version 1.13, and so changes made for 1.12 and 1.13 were lost.

(2) interface/new/new_patient_save.php appears to be a modification of 1.5 instead of 1.6, and so the 1.5 changes were lost.

Could you have your team correct these ASAP?

Thanks again!

Rod
www.sunsetsystems.com

13

drbosman wrote on Wednesday, April 16, 2008:

Will be fixed by tomorrow.

14

sunsetsystems wrote on Saturday, April 19, 2008:

Never mind, I fixed them myself.

Rod
www.sunsetsystems.com