bradymiller wrote on Thursday, July 28, 2016:
Hi,
Sharon from Matrix has submitted code for review to add Holidays to the calendar. I’ve already reviewed it and Sharon has already addressed the issues. I wanted to ensure the community had a opportunity to review it before I commit it to the codebase. The code can be found here:
thanks,
-brady
OpenEMR
bradymiller wrote on Friday, July 29, 2016:
Hi,
(since sourceforge was not sending out forum posts via email last night, I am repeating the following post)
Sharon from Matrix has submitted code for review to add Holidays to the calendar. I’ve already reviewed it and Sharon has already addressed the issues. I wanted to ensure the community had a opportunity to review it before I commit it to the codebase. The code can be found here:
thanks,
-brady
OpenEMR
bradymiller wrote on Sunday, July 31, 2016:
I just committed Matrix’s code to the codebase. Thank you for the contribution!
-brady
OpenEMR
arnabnaha wrote on Tuesday, August 02, 2016:
Tested it out…after uploading, importing and syncronising the csv file…the calendar doesnot show that 15th august is a holiday and also I can book appointments on 15th august without any alert given that its a holiday. I guess there are bugs in it
bradymiller wrote on Tuesday, August 02, 2016:
Hi,
What did the csv file look like that you used?
-brady
OpenEMR
arnabnaha wrote on Tuesday, August 02, 2016:
2016-08-15,Independence Day
2016-10-09,Durga Puja
2016-10-29,Diwali
2016-12-25,
bradymiller wrote on Tuesday, August 02, 2016:
Why no title for the 2016-12-25 entry?
arnabnaha wrote on Tuesday, August 02, 2016:
Thats a copy error. The original csv file does have a title. I have checked the calendar_external table in database also. Itcontains all the entries properly.
bradymiller wrote on Tuesday, August 02, 2016:
Hi Arnab,
I tried the following and it worked:
2016-08-15,Independence Day
2016-10-09,Durga Puja
2016-10-29,Diwali
2016-12-25,Christmas
Which Calendar UI are you using? Should be outlook.
Are you sure you clicked on Synchronize?
(note the success messages could be improved by stating which step was successful or else it can be unclear whether the process actually happened)
I wonder if this will end up being related to a windows end of line issue. You see any errors in the php log?
-brady
OpenEMR
arnabnaha wrote on Tuesday, August 02, 2016:
Hi Brady,
arnabnaha wrote on Tuesday, August 02, 2016:
Found out whats happening…If a doctor is scheduled in calendar on the day of holiday, and the front desk tries to book appointment within the doctor’s schedule…the appointment is booked without any alert. if the calendar is having no schedule for doctor, then only, it shows as a holiday and works. Scheduling on that empty calendar shows a message that its a holiday.
bradymiller wrote on Wednesday, August 03, 2016:
Hi Arnab,
Would you consider this a bug? It seems like this is a bug. How do you set the days you are in clinic (via recurrent weekday?).
-brady
Brady Miller
arnabnaha wrote on Wednesday, August 03, 2016:
Hi Brady,
I set the calendar for 6 months by setting the in time and making it reccurent. Same for the out time.
What the holiday feature should do is…for all those who have already setup their calendar, it should create an alert that the day is already scheduled…would you like tocreate a holiday entry? If yes, it should delete the schedule of the provider and create entry. If not, then it should leave that day as scheduled.
For new setup, one should import holidays first before setting up calendar and everything will fall in place
sharonco wrote on Wednesday, August 10, 2016:
Hi, i hope you like this feature.
If there are any “bugs” or things to improve we can do it as long as you tell us what to iimprove. Please open a bug and we will take a look at it
Thanks!
sharonco wrote on Wednesday, August 10, 2016:
Hi, i hope you like this feature.
If there are any “bugs” or things to improve we can do it as long as you tell us what to iimprove. Please open a bug and we will take a look at it
Thanks!