Fix for recurring appointment bugs in the Appointment Report

epsdky wrote on Wednesday, June 03, 2015:

Hello Brady,

I have put a fix for the recurring appointment bugs in the Appointment Report on GitHub here

It fixes both the duplicate and missing appointment problems.

Regards,

epsdky.

bradymiller wrote on Thursday, June 04, 2015:

Hi epsdky, Rod, and Ken,

Awesome. Testing well for me!

Ken and Rod,

Can you both look at this since it will be replacing the getRecurringEvents function, which you have both worked on. Especially Rod, whom added some more recurring appt options. My assumption is that epsdky’s code is now mimicking what the PostCalendar is doing to calculate the appointments, so should be the most accurate. Thoughts?

-brady
OpenEMR

sunsetsystems wrote on Thursday, June 04, 2015:

Hey epsdky, could you explain in a bit more detail what the problems are that are being fixed?

If it’s testing well for all types of recurring appointments then I don’t see a problem. It’s nice to see this contribution.

Rod
http://www.sunsetsystems.com/

sunsetsystems wrote on Thursday, June 04, 2015:

Oh never mind the explanation, I see there’s another thread for that.

Rod
http://www.sunsetsystems.com/

epsdky wrote on Saturday, June 06, 2015:

Hello Brady,

I have made the changes to the include files as you suggested. The updated file is here

Regards,

epsdky.

epsdky wrote on Sunday, June 07, 2015:

Hello Brady,

Please disregard the above link, I made a mistake updating the include file line
("/library/encounter_events.inc.php" should have been “/encounter_events.inc.php”).

An update is here

Regards,

epsdky.

bradymiller wrote on Tuesday, June 09, 2015:

Hi epsdky,

Was about to commit this with a couple very minor fixes:


(note I rebased all your commits into one)

But noted the following bug:
Create new patient
Create new recurrent appointment “every 2nd Monday” until about a year away
Go to Reports->Appointments
The appointment does not show up if do TO and FROM date for the day of visit.
It does show up if change the FROM date to about year away.

Let me know if you need more detailed information to recreate the bug.

thanks,
-brady
OpenEMR

epsdky wrote on Tuesday, June 09, 2015:

Hello Brady,

$occurance was not being set before “case ‘2’” code which matters here.

Regards,

epsdky.