Fancy Calendar questions

cfapress wrote on Thursday, February 07, 2008:

In order to get the CVS code to work with ‘fancy ui’ in the calendars I had to alter a line of code. I was getting this error:

"
Parse error: syntax error, unexpected ‘&’, expecting T_VARIABLE or ‘$’ in /home/www/openemrdev/interface/main/calendar/modules/PostCalendar/pntemplates/compiled/%%100/%%1004925654/fancy_template.html.php on line 183
"

And to fix it I did this:
  line 158 in file interface/main/calendar/modules/PostCalendar/pntemplates/default/views/day/fancy_template.html
  remove the extra ‘&’ in the foreach command

But even after that the fancy UI still doesn’t show up properly in my browser. I’m using IE 7. The calendar interface shows the buttons along the top of the calendar. Then a bunch of ‘am’ down the left hand side. At at the bottom is a white box.

oh… wait a second…

After I wait a little bit, switch IE tabs and then back to OpenEMR the new calendar UI does show up. Odd. I wonder if it’s due to some AJAX calls getting stuck? Or is it an IE bug?

jason

chemed wrote on Thursday, February 07, 2008:

1. Did you try clearing your browser’s cache?
There are no AJAX calls at all in the ‘fancy’ calendar. It is just a replacement Smarty template. A regular HTML page.

2. I did test it in IE7 and Firefox 2/3.

3. Why do you think the & is extra? What version of PHP are you using?

chemed wrote on Thursday, February 07, 2008:

I just looked up PHP docs here:
http://www.php.net/manual/en/control-structures.foreach.php

It looks like the & reference is only supported in PHP5. You are right, let’s remove the & from there.

sunsetsystems wrote on Thursday, February 07, 2008:

I committed this fix.  Thanks guys!

Rod
www.sunsetsystems.com

fred0 wrote on Thursday, February 14, 2008:

Just started playing with the fancy calendar. Right up front, the first thing I notice that is problematic is the provider’s name display at the top. IN the standard calendar, this was first initial and then last name. Very useful considering my clients are a married couple with their own clinic. The new fancy calendar displays last name only so, there’s no way to tell which one is which.
Also, the appt edit pop-up window size seems to be a bit shy in the height setting as I need to scroll down to see the buttons. This occurs in both Firefox & Safari (we use Macs). The crete new appt pop-up is sized well and the buttons are within the frame, but does scroll slightly.
Otherwise, it looks pretty neat so far.

chemed wrote on Thursday, February 14, 2008:

1) Provider’s name fix is easy. Just a small adjustment to a template.
2) Does “Appointment edit” window have size problems only in “fancy” layout, or in a default layout too?

chemed wrote on Thursday, February 14, 2008:

To fix provider’s name:
Replace one line in /openemr/interface/main/modules/PostCalendar/pntemplates/default/views/day/fancy_template.html

was: <div class=‘cal_column_label’>[-$provider.lname-]</div>

should be: <div class=‘cal_column_label’>[-$provider.fname[0]-]. [-$provider.lname-]</div>

fred0 wrote on Friday, February 15, 2008:

Ah-ah! I see what’s happening. The short answer is that yes, I get the same behavior from the pop-up in both standard and fancy calendar views. The long answer is that it’s the DOB missing warning that causes the buttons to fall outside the frame. If I click on an appt where the patient DOB is set, it all fits nicely. If the DOB is not set, the extra field makes the content larger and hence one has to scroll to the buttons.