bradymiller wrote on Tuesday, February 28, 2012:
Hi,
I just committed Craig’s above code to sourceforge (made a couple minor changes discussed in the github review). Thanks for the contribution.
-brady
aethelwulffe wrote on Tuesday, February 28, 2012:
Yes, and thank you very much Craig (and Brady too!) It’s a real help.
aethelwulffe wrote on Sunday, July 08, 2012:
PID bug cropped up again. No-one here mentioned it to me, they just stopped using it! We might wanna check out the dev-tip code or that last patch. Might have been bad since April.
aethelwulffe wrote on Sunday, July 08, 2012:
…Checked (not against the code base, just against the three sql queries listed in this thread) the three /library/dated_reminders.php query changes I am using, and they match the previous fix. I’ll go looking for the issue further.
aethelwulffe wrote on Sunday, July 08, 2012:
OK, with patient 101, everything is fine. With patients in the 1000’s, the log records the wrong name, and while stuff sent to myself reflects the correct patient, I am getting reports that for others, this is not so.
I am checking our patient number sequence in the DB to identify id/pid breaks, dupes, or other issues like that that may break the code.
aethelwulffe wrote on Sunday, July 08, 2012:
Yeah, around patient 440, the ID and PID stop matching. They are one off from each other. Checking the code for any instances using id vs PID
aethelwulffe wrote on Sunday, July 08, 2012:
$pSQL = sqlStatement("SELECT pd.title ptitle, pd.fname pfname, pd.mname pmname, pd.lname plname FROM `patient_data` pd WHERE pd.id = ?",array($drRow['pid']));
in library/dated_reminders_functions.php possibly. Everywhere else, this query has pd.pid.
aethelwulffe wrote on Sunday, July 08, 2012:
Two instances of the above in /library/dated_reminders.php line 366, and same in dated_reminders_functions.php, though I think one of these files must be legacy from an earlier version, just with a file name change.
bradymiller wrote on Tuesday, July 10, 2012:
Hi Art,
The use of id rather than pid does seem suspicious. Placed this possible bug on the release todo list to try to ensure it gets addressed before the release:
http://www.open-emr.org/wiki/index.php/QA/Release_Process#Tickets_Pending
-brady
OpenEMR
bradymiller wrote on Saturday, August 25, 2012:
Hi,
Just committed a fix for this to sourceforge (to the master and rel-411 branches).
-brady
OpenEMR