Code Review load_codes.php

juggernautsei wrote on Wednesday, July 08, 2015:

Brady/Rod,

I have added a function to import the CPT4 codes purchased from the AMA.
Link to Code

sunsetsystems wrote on Wednesday, July 08, 2015:

Thanks Sherwin! This will be a very useful addition. A couple of initial comments as I can’t seem to comment in your branch:

  1. Use $code_type_id instead of assuming code type 1.
  2. Get rid of tabs or other causes of inconsistent indentation.

I’ll try to find some time in a couple of days to look more closely.

Rod
http://www.sunsetsystems.com/

sunsetsystems wrote on Wednesday, July 08, 2015:

Also:

See lines 78-81 and 98-100. You should be able to do similar tests to pick out the LONGULF.txt file from the zipped bundle (is it a .zip?) and to omit undesired lines, thus not requiring the user to extract or edit anything.

Rod
http://www.sunsetsystems.com/

juggernautsei wrote on Monday, July 13, 2015:

Ok, thank Rod.

I will work on this and resubmit.

juggernautsei wrote on Monday, August 10, 2015:

Here is the updated code for review.
Link to Code on GitHub