Adjustment reason needed for every entry that is not being changed

juggernautsei · May 31, 2023, 12:09pm

This is the screen. On this screen, the user is required to select an adjustment reason for all the entries even though there is only one entry being changed.
In the past, they would add zero to the pay and adjustment and that would keep the notice from showing up. Now it shows regardless. The user is forced to select an adjustment reason not matter what.

@stephenwaite had mentioned in another thread to do something with the delcount. This is the logic that handles the error message to my knowledge. I will have to spend time getting to know how this works before I am able to address the issue to only check the box that is containing a value to make sure that the adjustment reason is added.

github.com

openemr/openemr/blob/75994f1089b0943311d90d7325825a11f1705f9f/interface/billing/sl_eob_invoice.php#L101

      
        
                const relement = f['form_line[' + code + '][reason]'];
                const tmp = belement.value - pelement.value;
                aelement.value = Number(tmp).toFixed(2);
                if (aelement.value && !relement.value) {
                    relement.selectedIndex = 1;
                }
                return false;
            }
            
            
// Onsubmit handler.  A good excuse to write some JavaScript.
            function validate(f) {
                let delcount = 0;
                let allempty = true;
            
            
    for (let i = 0; i < f.elements.length; ++i) {
                    let ename = f.elements[i].name;
                    // Count deletes.
                    if (ename.substring(0, 9) == 'form_del[') {
                        if (f.elements[i].checked) {
                            ++delcount;
                        }

PHPStorm is showing that line 123 is always true since the type string and type number have no overlap.

          if ((cPay !== 0) || cAdjust !== 0) {
                allempty = false;
            }

Unresolved variable

       ins_done.value

Any input would be great. I am following the IDE for now to correct some of the things the IDE is pointing out

stephenwaite · May 31, 2023, 12:36pm

hi @juggernautsei , there’s a setting in config:
Disable Auto Adjustment Calculations in EOB Posting

juggernautsei · June 13, 2023, 2:50am

Hi @stephenwaite, I disabled what you shared with me and the program is still doing the same thing.

I fixed it by changing this line here. From this

 if ((cAdjust !== '0') && !f[pfx + '[reason]'].value && !adjDisable) {

To this:

 if ((cAdjust !== '0.00') && !f[pfx + '[reason]'].value && !adjDisable) {