2.8.2 Full Encounters bug

OpenEMR Development
1

duanemorrow wrote on Thursday, March 22, 2007:

Version 2.8.2
Frames enabled

I go to a patient and in the bottom frame it lists his encounters. At the very bottom there is a link that says:

"Some encounters were not displayed. Click here to view all."

I click that link and it opens a new tab/window with a full encounters listing.
There are no frames. If I click any encounters in this new window nothing happens.

This occurs in both internet explorer and firefox.

I’ve tried it on three different computers.

2

drbowen wrote on Thursday, March 22, 2007:

This always been this way and has "bugged" me for a long time.  It would be nice to get this fixed.

Sam Bowen, MD

3

duanemorrow wrote on Friday, March 23, 2007:

I went in and edited openemr/interface/patient_file/history/encounters.php
Can others check it out and if okay can a developer make a change and check it into cvs.

original code has a target=‘Main’ in it…

    if ($count > $N) {
      //we have more encounters to print, but we’ve reached our display maximum
      print “<tr><td colspan=‘4’ align=‘center’><a target=‘Main’ href=‘encounters_full.php’ class=‘alert’>”.xl('Some encounters were$
      break;
    }

I removed that and it seems to be working correctly …

    if ($count > $N) {
      //we have more encounters to print, but we’ve reached our display maximum
      print “<tr><td colspan=‘4’ align=‘center’><a href=‘encounters_full.php’ class=‘alert’>”.xl('Some encounters were$
      break;
    }

4

duanemorrow wrote on Friday, March 23, 2007:

watch out for the bad text pasting job of this code…but you can see the change that was made.

5

sunsetsystems wrote on Friday, March 23, 2007:

Actually I recently removed the 20-encounter limit from encounters.php, so it always lists them all and encounters_full.php is now obsolete.  I think it was pretty silly to have this "optimization" when the volume of HTML in other pages like the calendar can be huge by comparison.

If the limit is ever reinstated, then I would want to see a more sensible paging mechanism for it.

Rod
www.sunsetsystems.com