Zend Module Installer

OpenEMR Development
#81

zhhealthcare wrote on Wednesday, February 26, 2014:

Hi Brady,

Made the suggested changes and posted reply comments. The commit path is

The first commit(40636fc6b1ba0444c878e438790a4afb1b2b1876) is the changes to bring module installer into openEMR.
The second commit(efa709e9480992049de4c7608c93643be91e8327) is a sample module.
The third commit(9af9117be3f7956f461b66be99450b1517d92890) is the ZF2 library to allow testing the code with default library.

Please review.

Thanks and Regards,
ZH Healthcare

#82

zhhealthcare wrote on Friday, February 28, 2014:

Hi Brady,

Made the suggested changes and posted reply comments. The commit path is :

The first commit(626bfe355ddbdef77905fd12e5a870b9201a7932) is the changes to bring module installer into openEMR.
The second commit(45b5c3d58c99feab55ed5f0375188276c3bfd15e) is a sample module.
The third commit(5a1f86ff1c6a703fd94e67c089c1cc16d4c7be3d) is the ZF2 library to allow testing the code with default library.

Please review.

Thanks and Regards,
ZH Healthcare

#83

bradymiller wrote on Tuesday, March 04, 2014:

Hi ZH,

Plan to review this soon.

For those whom are just testing code, note this code can be tested in the following UP FOR GRABS demo:
http://www.open-emr.org/wiki/index.php/Development_Demo#192.168.1.130

thanks,
-brady
OpenEMR

#84

cmswest wrote on Tuesday, March 04, 2014:

thanks Brady, i tested out the “Tester” by installing and uninstalling and it seems to work fine as the screen refreshes to show the Tester module added under Modules in left nav

however, when i tweak the acl for administrator and disable the module i have to log off and log back in to redisplay tester. not sure if this is desired as it differs from the refresh that occurs when you install/uninstall

so you can have a situation like the attached photo where i think you should see the tester module in the left nav

#85

bradymiller wrote on Sunday, March 09, 2014:

Hi ZH,

Just placed review on github. If possible, I’d place the commit for your “ZH Care Coordination Module” within the commits for your next revision (for example, commit 1 is your Module Installer revision(likely final revision :slight_smile: ), commit 2 is the Example Module, commit 3 is the Zend library, and commit 4 is the “ZH Care Coordination module”). For the care coordination module, just make sure you follow all the stuff you did in the Module Installer code (html escaping, translations, etc.) and bring in the new lists and database columns for now(can figure out how to merge them into the codebase when can see it all clearly).

Now it’s starting to get very exciting :slight_smile:

-brady
OpenEMR

#86

bradymiller wrote on Sunday, March 09, 2014:

Actually, because of the size of this stuff will be better to separate your ZH Care Coordination Module into 2 commits:

  1. The code
  2. The database modifications

thanks,
-brady

#87

bradymiller wrote on Sunday, March 09, 2014:

Additionally,
I also confirmed Stephen’s bug that he reported above.
-brady

#88

zhhealthcare wrote on Friday, April 04, 2014:

Hi Brady,

Made the suggested changes to the Module Installer and also committed the care coordination module that is required for MU2. The commit path is :

The first commit(dc90f53b4ccfdc46f794b4698f827ad3a38a4a8c) is the changes to bring module installer into openEMR.
The second commit(fe629016e0ff680f0b2db0bf051a222bd574e35c) is a sample module.
The third commit(a6ed1580492f74f31d61ebe34cddcb146dbeb968) is the ZF2 library to allow testing the code with default library.
The fourth commit(af58d69883406df1ca9c3667ac0db758fe05197c) is the care coordination module.
The fifth commit(25e3e318adc1a7971a2d48f38f61eeab6fe0c397) is the database changes for care coordination module.

Please review.

Thanks and Regards,
ZH Healthcare

#89

bradymiller wrote on Saturday, April 05, 2014:

Hi,

I set up a “up for grabs” demo here:
http://www.open-emr.org/wiki/index.php/Development_Demo#192.168.1.130

Goal is to get this reviewed (both the module installer and care coordination modules) over the weekend.

-brady
OpenEMR

#90

mdsupport wrote on Saturday, April 05, 2014:

Says Carecoordination module not enabled 'cos of Lab module dependency.

#91

bradymiller wrote on Sunday, April 06, 2014:

There’s a bunch of database stuff in the upgrade script and not the primary database.php script. On the next demo restart at 9:02 am PST it will bring in this data (I just had to change a setting for the demo), so guessing will work better. (note I didn’t expect this to work right away; one of the main goals of this first revision is to figure out what to do with database changes in a OpenEMR friendly way)
-brady

#92

bradymiller wrote on Monday, April 07, 2014:

This is a nice starting point,

I placed a review here:

-brady
OpenEMR

#93

zhhealthcare wrote on Tuesday, April 08, 2014:

Hi Brady,

Made the suggested fixes and posted comments in the Module Installer and care coordination module. The commit path is:

The first commit(e1f86b41c4d90e72243e90f3d3a06fe0f25f4c71) is the changes to bring module installer into openEMR.
The second commit(1b77eb2b3214dbd777148948a8c3d16370536e3e) is a sample module.
The third commit(0f36fd1de2fcf42971a145ee2bb5ef53469c8a16) is the ZF2 library to allow testing the code with default library.
The fourth commit(0c334c6e9d3113c0dc5bd89e47dbc31a170da776) is the care coordination module.
The fifth commit(b256821687ba7002bba8aa7f90d83d712cb5aa79) is the database changes for care coordination module.

Please review.

Thanks and Regards,
ZH Healthcare

#94

bradymiller wrote on Monday, April 14, 2014:

Hi ZH,

Placed a review for the Care Coordination modules stuff here:
https://github.com/zhhealthcare/openemr/commit/b256821687ba7002bba8aa7f90d83d712cb5aa79

-brady
OpenEMR

#95

bradymiller wrote on Monday, April 14, 2014:

Also,

Placed the review for the Module Installer here:

-brady
OpenEMR

#96

zhhealthcare wrote on Thursday, April 24, 2014:

Hi Brady,

Made the suggested fixes and removed unwanted code from the Module Installer. The commit path is:

The first commit(dcb9fbe47eadbc69bec0f4b23140864db175ff67) is the changes to bring module installer into openEMR.
The second commit(018bd28e35c6703532983c966040d05fddfadaf6) is a sample module.
The third commit(2ffce429feb85a2066dba2e3e047765934e78505) is the ZF2 library to allow testing the code with default library.

Please review.

Thanks and Regards,
ZH Healthcare

#97

bradymiller wrote on Monday, April 28, 2014:

Hi,

Placed review here:

-brady
OpenEMR

#98

zhhealthcare wrote on Thursday, May 29, 2014:

Hi Brady,

Made the suggested changes and put comments in duplicate functions. The commit path is:

The first commit(6516e38daff339a488757f33b07ec9004bf2c7ab) is the changes to bring module installer into openEMR.
The second commit(ad43671ad7ddc604750f400ee0e4ee314dbae58f) is a sample module.
The third commit(f44460f84e2755f73acd808ccbda3aa487af71d2) is the ZF2 library to allow testing the code with default library.
The fourth commit(0e94b9eed5b974b255332929fd744d750ae5d23b) is the care coordination module.
The fifth commit(2236d4077285f54882671379282cf813a31bb7f9) is the database changes for care coordination module.

Please review.

Thanks and Regards,
ZH Healthcare

#99

bradymiller wrote on Friday, May 30, 2014:

Hi,

thanks. will plan to review it over the weekend.

Code can be tested by all on the following “Up for grabs” demo:
http://www.open-emr.org/wiki/index.php/Development_Demo#192.168.1.130

-brady
OpenEMR

#100

bradymiller wrote on Monday, June 09, 2014:

Hi ZH Healthcare,

On the above demo(which is using your code), unable to find where the new functionality is within OpenEMR (after I install the modules). I remember getting an email at some point directing me where it was in the past, but can’t locate it.(will be good for others testing this to also know where it is)

thanks,
-brady
OpenEMR