Hi @juggernautsei and @sjpadgett ,
There are 2 separate issues here, which are both related to the future proofing of the Smarty code in OpenEMR:
First issue that @juggernautsei brought up is that we should not be using native php code in the templates (or else we will never be able to migrate to Smarty version 3 in the future). Using native php in templates is not supposed to be done and is not allowed by Smarty version 3. At the place you pointed out, I removed the native php code and instead used Smarty syntax to do the same thing. I did just confirm that this is working on the development demo (If I turn on the Administration->Globals->Connectors->‘Enable Weno eRx Service’, then the ‘Transmit Rx’ button does show up).
Second issue is escaping. This shouldn’t cause issues since it’s not really adding quotes(if it is, then let me know and I’ll look into it). It instead converts quotes and other html things like < and > to (i think the UTF8 equivalent), so it’s then not seen as being ‘html’ code.
thanks,
-brady