User Interface Renovations

OpenEMR Development
#35

mindfeeder wrote on Saturday, January 16, 2016:

Looks very nice John but, there are a lot of broken things. :confused: I can tell you’re close though. Wonderful Job…

Just with limited time, quick bug report…

Selecting patient, then encounter; does not pop up forms in bottom.

Patient Prescriptions: search box pops underneath text box below.

Print Calendar view pops up quickly and dies. (I killed adblock (this maybe a Chrome Thing)

However, very pretty. I played with a demo earlier and these functions were working fine.

All the best,
-Kyle

#36

syednaibali wrote on Wednesday, January 27, 2016:

Hi All,
Bootstap_style.css theme is looking superb .
Is OpenEMR 4.3.0 upcomming version have bootstrap_style.css theme ??
Thanks

#37

tonyarra wrote on Thursday, February 11, 2016:

Hey All,

I’m Tony, a senior software developer working for Practice Provider, and I recently began the “ui-phase2” branch of our fork. The frame-changes that were made during phase 1 have been reverted. It caused too many DOM issues. We would still like to eventually move from framesets and frames to divs and iframes respectively, but not at this stage of development.

Many of the bugs that were mentioned in this thread have been fixed in this new branch. I’ve also started an issue tracker at the fork that you are free to contribute to. I look forward to getting our fork to the point where it can be merged into the main repo.

#38

mindfeeder wrote on Friday, February 12, 2016:

Hey Tony, this is great. I would say you’re a step away from production. I played with it yesterday and today and ported out aa production system to test with. The only thing I’m seeing atm is in the prescription modual that’s buggy. I really couldn’t find your reference for where it’s searching. I think you have an ?drug_id string of some sort in there but, I didn’t dig enough to find what you’re pulling form. Currently when “Click to search” is used; the popup dialog doesn’t format proper nor, does it search the RXNorm database… It’s not a huge thing, as most prodivers would know the drug but, still a hiccup. Otherwise I ran it through the motions since yesterday.

Attatched is a screenshot of what I’m talking about.

Also, in the fee sheet… when clicking on the CPT code to auto adjustify, there seems to be an alignment issue. Screenshot attatched as well.

Otherwise, I see nothing major. Kudos Tony!!

#39

mindfeeder wrote on Friday, February 12, 2016:

Printing receipts and ledgers also seem to be a bit bugging. Reciept for payment has no call to print and printing a large ledger seems to garble the facility information up top… However, it is worth mentioning I merged from the 4.3-dev release off git… sql calls have been changed a bit. Just a heads for whatever it’s worth. However, claims print fine, Patient summaries print fine, etc… I didn’t run into any other print errors. If I have the time this weekend… I’ll may run a full compare on the two with your UI on 4.3. I don’t know if you’ve looked at that branch and are familiar with the changes? Quite an undertaking btw, you’ve been all over the code as far as I see… :wink:

All the best,
-Kyle

#40

bradymiller wrote on Saturday, February 13, 2016:

Hi,

I directed the following demo to this so folks can easily test it here:
http://www.open-emr.org/wiki/index.php/Development_Demo#192.168.1.131
(to see the new modern theme, select Adminstration->Globals->Appearance->Theme->style_bootstrap.css)

-brady
OpenEMR

How do i change theme styles or create a new one
#41

mdsupport wrote on Saturday, February 13, 2016:

Is there a way to balance sizes of labels and actual data?

#42

tmccormi wrote on Saturday, February 13, 2016:

CSS just needs to have a different “button” type style for these kinds of inline buttons/links.

#43

robertdown wrote on Monday, February 15, 2016:

This work has inspired me to continue my modern theme. I’ve taken the advice of a purely CSS theme, no changes to the actual codebase. Here are some screenshots.

#44

bradymiller wrote on Tuesday, February 16, 2016:

Hi Tony,

I rebased all your work into 1 commit on top of the most recent codebase (I did forget to add the .gitignore file since the copy command didn’t copy files prepended with a period) and I also placed a review of the code there:


(please see my comments on the commit by searching for bradymiller)

Here is the branch that contains this code:

It took awhile to fix the merge conflicts, so please now work from this new branch(feel free to add your .gitignore file to it also).

-brady

#45

bradymiller wrote on Tuesday, February 16, 2016:

Hi Tony,

Just so you know, the goal is to get your work into the main codebase as soon as possible (and I do think it is getting close). Then there is another developer whom is currently working (in the alpha stage) of dealing with the frameset issues; and that developer can then integrate your styling into his work:
https://sourceforge.net/p/openemr/discussion/202506/thread/e3356721

-brady

#46

bradymiller wrote on Tuesday, February 16, 2016:

Hi Robert,

What code is your styling based on?

-brady

#47

robertdown wrote on Wednesday, February 17, 2016:

For now I’ve just copied the default style and began rewriting. Eventually I want to incorporate the Bootstrap foundation, but for now it is just easiest to tweak a current theme.

Inspiration came from the current iteration of Microsoft Office.

I’ll post the github repo momentarily. Just need to clearn up and commit my latest changes.

#48

yehster wrote on Wednesday, February 17, 2016:

One big concern with what’s going on in this restyle is adding new classes (so there is both title and title-custom now…) Seems much cleaner to fix the existing “title” class rather than introduce a new one.

Robert’s approach of improving the existing CSS theme is more straightforward, rather than introducing a whole new set of CSS classes.

The problem with the existing CSS themes is that they aren’t applied consistently because of the larger number of authors in the project. (some buttons are links, some are input tags, some are button tags, just as one example)

The end goal should not just be the nicest looking style changes, but the most consistent application of css tags.

#49

yehster wrote on Wednesday, February 17, 2016:

It is a little worrisome to see such extensive changes, in so many files, especially when there are more than just css class modifications.

#50

tonyarra wrote on Wednesday, February 17, 2016:

Thanks Brady, this is great! Well continue working from this branch. Hopefully we can wrap this up quickly, and integrate the frameset changes in later on from Kevin’s fork.

#51

bradymiller wrote on Wednesday, February 17, 2016:

Hi Kevin,

The end goals of the UI project was to:

  1. Have a product that actually entices potential customers.
  2. Use least invasive method possible.
  3. Continue to support the older themes.
  4. Leave the specifics of the solution to whomever was willing to do all the work.

Practive Provider has been working on this in the public domain for at least 4 months now. Several code changes were needed to support the GUI pills in addition to some other GUI related items. Having a couple extra classes is not something that struck me as an issue when I was doing the review.

-brady
OpenEMR

#52

tmccormi wrote on Wednesday, February 17, 2016:

Standardized classes is very important to the long term ability to support other kinds of UI, like mobile devices. We really need to make the use of standized classes part of the review/acceptance criteria as much as possible.

#53

robertdown wrote on Wednesday, February 17, 2016:

All of my changes only leverage currently used classes, I’m not adding anything new. But I do agree that we should push for a stronger standardized UI implementation. I have noticed a LOT of redundency in the CSS, I’m sure it also exists in the HTML as well.

#54

tonyarra wrote on Tuesday, February 23, 2016:

Hey Brady,

I made some bugfixes on your rebase-ui-phase2_1 branch and pushed it up to our fork. Let me know if this looks correct git-wise.