system
(system)
June 2, 2012, 4:56pm
1
tmccormi wrote on Saturday, June 02, 2012 :
This branch has code contributed by Art / aethelwulffe, it looks good to go. will commit it later today if no one has any objections
Mods for X12 to add isa01-04 / User Login and Password for some clearing houses
https://github.com/tmccormi/openemr/tree/add_isa01-04
Tony
system
(system)
June 2, 2012, 7:18pm
2
bradymiller wrote on Saturday, June 02, 2012 :
Hi Tony and Art,
Looks fine. A nice thing to do when committing somebody else’s code is to change the author name:
git rebase -i HEAD~1
change pick to edit
save/exit
git commit -amend -author=“Author Name <email@address.com >”
git rebase -continue
helpful for two things:
1. easier to know who coded it in the future
2. helps the project by adding another contributor
-brady
OpenEMR
system
(system)
June 2, 2012, 7:41pm
3
tmccormi wrote on Saturday, June 02, 2012 :
Planned on that… it whined at me when I tried it the first time, but I’ll do that with the commit to the master
-Tony
system
(system)
June 3, 2012, 4:51pm
4
tmccormi wrote on Sunday, June 03, 2012 :
This enhancement has been committed…
commit 587adbd8e10296076feea1c534131cfa2dc536a7
Author: Art Eaton <Art@Starfrontiers.org >
Date: Mon May 28 12:46:05 2012 -0500
Mods for X12 to add isa01-04 / User Login and Password for some clearing houses
library/Claim.class.php
library/classes/X12Partner.class.php
library/gen_x12_837.inc.php
sql/4_0_0-to-4_1_0_upgrade.sql
sql/database.sql
templates/x12_partners/general_edit.html
version.php
system
(system)
June 4, 2012, 7:14am
5
bradymiller wrote on Monday, June 04, 2012 :
Hi,
Thanks for the contribution, Art.
Will need to add the copyright/licensing info back to library/gen_x12_837.inc.php . Guessing just a simple mistake and I should of picked it up when I read through the code above.
thanks,
-brady
OpenEMR
system
(system)
June 5, 2012, 7:13am
6
bradymiller wrote on Tuesday, June 05, 2012 :
Hi,
just committed fix to add the copyright/license information to library/gen_x12_837.inc.php
-brady
OpenEMR
system
(system)
June 5, 2012, 1:09pm
7
tmccormi wrote on Tuesday, June 05, 2012 :
Thanks Brady. Don’t know how that got dropped
-Tony
system
(system)
June 9, 2012, 8:53am
8
bradymiller wrote on Saturday, June 09, 2012 :
Hi,
Just committed fixes for this feature in the sql upgrade script:
http://github.com/openemr/openemr/commit/ae356311f27e221e30c365f7728499c910180142
(Thanks to Visolve for reporting the bug)
-brady
OpenEMR
system
(system)
June 29, 2012, 10:16pm
9
weesnerkim wrote on Friday, June 29, 2012 :
Hi Art and Brady
I bill medicare directly using the GPNET dialup connection. I am looking into this change in hope to provide the extra login and password required. I spawn ProCom from the billing_process.php module and it dials up GPNET, logs in and sends the X12 batch. This works good all except the parameters are hard coded.
Good work art.
Kim Weesner