robertdown wrote on Sunday, April 13, 2014:
Yup, I didn’t add the most important file… the actual CSS. The new_event branch is updated.
bradymiller wrote on Monday, April 14, 2014:
Hi Robert,
No need for a pull for the demo. It’s grabbing your code directly from your repo when it restarts every morning. I did manually restart the demo and it does look better, however the message panel on bottom is still missing styling and the text on all scripts is very big.
Haven’t looked at the code yet in detail. When was the code last updated to most recent OpenEMR codebase?
-brady
OpenEMR
bradymiller wrote on Monday, April 14, 2014:
Couple other things I noted, is there’s no Logout etc. on top right and there are no icons showing in the left menu as is in the above screenshots.
robertdown wrote on Monday, April 14, 2014:
If you switch to the modern style the top bar should be fixed - but I tried on the demo and it wasn’t working. It just kept loading the oemr style. I imagine that’s what’s causing the icon issue as well
robertdown wrote on Monday, April 14, 2014:
Last code pull from the codebase was in the last 3 days, I believe. The people behind the Foundation CSS framework went super big with text, padding, and margins… I’m still shrinking things down.
mdsupport wrote on Tuesday, April 15, 2014:
The styles make pages usable on tablets. Almost every user was very pleased when your pages were seen on 10" screens. We have had same reactions when we started using new jQuery ui components - oversized calendar on normal monitors become widgets with perfect sized numbers to touch on tablets.
Here are initial observations -
- The UI looks really promising.
- From styling perspective it may be good to drop the little pictures of patients, calendars or show only pictures or text but not both.
- Not sure if you are touching the inline styles but they seem to cause lot of issues with themes.
- Links in this package are amazingly diverse - they can be buttons, text hyperlinks, event driven textboxes or whatever… This may be an appropriate time to standardize it - be it buttons or popup offering menu actions like patient search at top of left menu.
- Not sure if zend will play nice with this.
robertdown wrote on Wednesday, April 16, 2014:
Thanks for the feedback, glad to hear the changes are well received. I’m especially glad to hear that the new UI is working on tablets - that was a big concern of mine and an issue I hope to address every step of the way.
Re #2, are you talking about the menu on the left nav? Icons are present in the current UI and I feel (just my humble opinion) that the new icons add a bit of differentiation to the menu. As a user, I imagine it’s a lot easier to scan for a picture rather than a word - off the top of my head, it probably wouldn’t be too hard to add an option to the users’ preferences: Icons Only, Icons + Text, Text Only. I’ll look into the details of that.
Re #3, which areas are you seeing issues? A lot of the old UI won’t survive the modernization, so as I complete a page I force the new CSS into that page ensuring that any old CSS doesn’t destroy the new UI. Once we’ve completed all the screens I’ll pull out the hard code and move back to just the user selected CSS.
Re #4, my rule of thumb is to use hyperlinks unless I’m in a form. Of course, I will generally stylize the link to look like a button, but the underlying code is in fact an anchor. Initially I had the patient search bar on the top nav with a similar popup to change how to search, but because the top nav is not very tall, the popup, when expanded, is hidden by the main iframe. I’m still toying with a possible vertical slide out and keep that search bar on the top (I think there is just a bit too much going on in the top left corner at the moment. Since we’re speaking of menu actions and such, something I’d like to add (no time soon, it’s low on my to-do list) is float the idea of adding contextual menus to the calendar. This could expedite the “check-in” process as the receptionist would only have to right click on the patient and slick the appropriate status. Just a thought.
Re #5, Zend should play fine with this as it’s at this point just HTML/CSS (minor JS) updates.
Attached are a couple more pictures (I’ve also pushed this code, not sure if I got the changes pushed in time for the nightly rebuild) of the Add / Edit Event screen. You’ll see what the screen looks like w/o a pt’s contact info, w/ the contact info, and w/o a DOB. Functionally I believe the screen to be nearly ready for a pull request, I’d love any/ever-one to attempt to break it and crash it, all that fun stuff. One issue I’m still working on is the date-popup screen - it will require some TLC during the modernization.
Robert
bradymiller wrote on Tuesday, April 22, 2014:
Hi,
Here’s a example of the encoding issue for the icons we were discussing on the conference call. The right screenshot is in chromium web browser (it works) and left screendhot is in firefox (not working). OS is mint 16.
It looks like it may be related to semantic issues in the css code, but I haven’t researched it that much:
-brady
OpenEMR
robertdown wrote on Tuesday, April 22, 2014:
Thanks, I’ll look into this
robertdown wrote on Saturday, May 31, 2014:
Updates
epicstar wrote on Monday, June 09, 2014:
Is there an alternative to the HTML frames currently used now? They’re pretty much old school atm…
robertdown wrote on Friday, June 13, 2014:
I don’t think there is an alternative. It’s something I’d like to work on, but it’ll be a long time before I can get to that - it would likely be the biggest rewrite we’ve seen in years.
robertdown wrote on Friday, June 13, 2014:
Here is a commit that has been squashed and (I believe) is up to date with upstream/master. It contains the modernization changes to the left nav and main title pages. I have a couple of CSS things to tinker with, but I feel this is close enough to being down to submit it for code review.
https://bitbucket.org/rdown/openemr/commits/101caefbb2d7640e4f5a912f6b40fac99d9405f8?at=master
fr4nkie wrote on Friday, June 13, 2014:
This is going to be a fantastic upgrade. Really looking forward to the implementation. Appreciate the hard work Robert!
robertdown wrote on Saturday, June 14, 2014:
Thanks Frankie, hopefully we get this integrated quickly 
robertdown wrote on Saturday, June 14, 2014:
Turns out there was some issues with keeping my feature branch up to date with the master branch, so I need to do some fixing before the changes are production ready.
Here is the first fix, the left_nav.php has been completely refactored for PSR2 (fig-standards/PSR-2-coding-style-guide.md at master · php-fig/fig-standards · GitHub) compliance. I haven’t added any modernization changes, just simply brought the code standards up to par. I’ll do the same for the main_title and login screen pages and post here. Then I’ll introduce the modernization changes into each page, squash the commits into 1 and submit that commit for the actual big change.
So here is left_nav.php refactored to PSR2 (Minus a few Warnings): https://bitbucket.org/rdown/openemr/commits/de8667279495dc8758aef5c2fea186b07e06c14b
That commit is ready to be merged into master
robertdown wrote on Saturday, June 14, 2014:
main_title.php refactored https://bitbucket.org/rdown/openemr/commits/aba95f66b20b5e17b3df3612ba6c6d2e8ae1876a
robertdown wrote on Saturday, June 14, 2014:
login_frame.php refactored https://bitbucket.org/rdown/openemr/commits/9ebd13735ecb0c8efeb4ec97fbf23b908d57a621
bradymiller wrote on Sunday, June 15, 2014:
Hi Robert,
Will be better to keep your above PSR2 commits separate. Then we’ll clearly see what you are doing with the modernization code (in future, you won’t need to do this for the code walk through, but for developers to have clear idea of what your doing for these commits). Is it ok to commit these three PSR2 commits now to the official codebase or would that mess up your current modernization stuff/work-flow?
-brady
OpenEMR
kickme345 wrote on Monday, July 14, 2014:
Hello Cesarus,
I am also using bootstrap to customize the ui of openemr and so far im changing the summary page…how’s your process? it would be great if u could give me some suggestions.```