The above commits should be ready to go into the codebase now and since it’s easy to switch between the tabs and old layout, we can then work out bugs etc. in tabs layout as it gets more use over time. I placed information on the Active Projects page with the plan: http://www.open-emr.org/wiki/index.php/Active_Projects#Frame_Removal
It is quite unprofessional that the commits only have attribution to me in the comments and not the commits themselves and also for you to add a copyright and licensing statements to the files of mine which are original.
I have sent you several emails and github posts regarding this project with no reply(unprofessional??). I was under the assumption that your interest in this had gone stale. Now that you are actually replying, I can easily make you the author of these commits if you wish and I can change the copyrights(do note that all the copyright and author info in all the new files have been assigned to you) to whatever you wish (I pulled it from a GPL repo, so I am safe to assume that it was GPL’d, correct?). I have made changes, but I don’t care about attribution; I just care about getting this into proper shape to get it into the codebase before I am using a walker…
On a technical issue regarding using JSON vs a database tables set to store the menu. The database tables set seems redundant and you have a really nice way of storing it in JSON. Would it make sense to just store the json structure in the database (in a TEXT field)?
Maybe a table with (id, date, category, json_data_menu)
Then would get following benefits:
Have a standard menu structure that can not be modified and is used by the project to add new items and ugprade etc(would be standard category with id 1), which users default to if not set to use another menu.
Allow user to create new categories to store new menus that can be used by users, user groups, etc.
Never overwrite custom sql row entries. Always add a new entry when change things. Thus can undo to old menus if wish.
Have a nice menu editor gui that grabs from and stores to the json structure (ie. remove the middleman sql table set).
I am a bit perplexed why this code is being held up. The only response I have received from you regarding this code is where you pointed out my unprofessional behavior in attempting to integrate your work into the codebase; it is notable that integration work does take up valuable OpenEMR volunteer resources. I am again getting no response from you via forum or email on how you wish for me to handle the copyright/licensing issue. I hope you are not considering revoking the GPL license to this code which would bring with it legal/ethical/moral flags.
Do note that you placed your code without headers inside a GPL3 licensed public codebase several months ago(and have also announced it here on the forums):
And do note that since your code is public, it has already been conveyed/propagated.
And also note that the author of the code is the default copyright holder if it not explicitly listed.
Thus the license/copyright headers I added were just making what was already implied to be explicit.
It appears my only recourse to get this project back on track in a palatable fashion will be to remove the license/copyright headers and make them all blank again (ie. placing them back in their original state); and thus using implicit licensing/copyright. I’d rather not do this, but I do think this feature is worth this hassle and will proceed in that direction if I do not hear from you.
We are only currently using icons in 2 places (in the left_nav menu and in the tab layout that will soon get into the codebase). So, we are nearing an ideal time to choose one. Also, is typicons even in the above comparison?
Dear Kevin,
As one of the supporters of this innovative interface after I tested it on the demo in April, I feel very unhappy with the present situation. I hope you would review your position in the interest of the open-source community and have your codes integrated into the codebase for all to use. Thanks.
Kayode
I’d like to press ahead on this project. Any feedback on the code/feature itself?
If no issues, then will place this in the codebase. Also, according to my logic above (and since I have not heard back from Kevin), I will add the standard GPL/copyright headers to it.
I’m a bit concerned about this going stale again before conversion is complete, as it requires extra work to maintain both old and new methods. Kevin, are you still around? Anyone else prepared to run with this ball?
I am happy to take this project on (I think it will be an important component in OpenEMR’s quest for modernization); if it does stale out, then easy to remove it (one of the nice things about this code is that it is very well modularized). I’d like to get the go ahead to place this into the codebase
Here is the branch with the commits:
1.Commit to bring in the third party packages via bower:
2.Commit that modified the code to work with current codebase(I added the standard gpl headers to the scripts as discussed above):
3.Commit that brings in a new menu item (an example of how easy it is to add a new menu item):
Hello All,
I have tried my hands on the demo of the iframes. It looks awesome and simply wow…I would suggest that the topmost dropdown menu (image below) should be spaced a bit…its too crowded on one side…with a big space between between the last menu item “About” and the user menu showing “Administrator”. may be small icons along with the menu names and spacing it out properly will improve the look more.
