mukoya wrote on Wednesday, March 23, 2011:
Downloading todays build right away. Will test and see.
Mukoya
mukoya wrote on Wednesday, March 23, 2011:
But again, Unless Brady has committed this changes, no need to waste my bandwidth. I do not see such a commit to both rel-400 nor master. The newly created forms for 4.0 repository appears unavailable as well.
zhhealthcare: Did you actually recently alter this form? If so, kindly provide the link. Will be greatly appreciated.
Mukoya.
zhhealthcare wrote on Friday, March 25, 2011:
Sorry for the wrong information that, the code has be committed.I will give you the link for patch as early as possible. In the mean while it can be reviewed, so that it can be absorbed to the main code base.
Thanks
Paul
mukoya wrote on Friday, March 25, 2011:
Thanks. Looking forward to the link.
zhhealthcare wrote on Friday, March 25, 2011:
I have corrected the code and updated in git to the branch
(doc_db_to_file_correct) accessible at
https://github.com/zhhealthcare/openemr/tree/doc_db_to_file_correct
The patch file is uploaded with name
‘0001-The-form-Scanned-Notes.patch’ at the tracker
https://sourceforge.net/tracker/?group_id=60081&atid=1245239
Thanks
Paul
mike-h30 wrote on Friday, March 25, 2011:
The form ‘Scanned Notes’ is modified to upload files.
Where is this form located? I am looking at today’s demo and I do not see a form called “Scanned Notes” in the list of forms or document categories? Thanks.
-Mike
aethelwulffe wrote on Friday, March 25, 2011:
I don’t quite know what to do with a .patch file, but I suppose I could copy and paste the code from the git branch….
mukoya wrote on Friday, March 25, 2011:
Thanks very much.
Form is now able to upload successfully and display a list of its contents including comments and file name in encounter summary. However, I am unable to open and view the actual uploaded content if in picture format.
A file name and an icon are presented in the summary but these are not links and clicking edit does not help. have tried this with jpg, png, gif, tif without success. I have reinstalled OEMR twice, the second time creating an entirely new database just in case DB contained wrong entries from my previous attempts
For other documents- I have tried pdf, word, powerpoint, txt and the .bmp picture format.- they work perfectly, only issue is that firefox presents its usual download wizard and when you click open, opens the document with default program in a separate window. Not a big bother but i think it would be better to open it within the user interface, rather than a new word, or adobe reader or windows picture viewer window.
For those that work, there is no link or preview to the file as such, the content is downloaded during when you click “save” or “edit”. there is also no preview. (similar to one posted here for 3.2 by aethelwulffe)
All in all, this is a big step as most scanning jobs can be saved as pdf or bmp anyway.
Mukoya.
Mukoya.
mukoya wrote on Friday, March 25, 2011:
Mike, aethelwulffe,
What I usually do is to clone the relevant repository-In this case “https://github.com/zhhealthcare/openemr.git”, switch to the relevant branch (as given above) and there, you find your precious files-in this case scanned notes form. Please follow this link and checkout at least post 9 for details about how i (non-expert) personally go about it.
https://sourceforge.net/projects/openemr/forums/forum/202504/topic/4045074
Mike, note that the said forms are part of many contributed forms that are not installed by default and have to be copied from the contrib folder to interface/forms on your own installation. they will not be found on the demo. as at now, the form does not appear to have been committed to main repository anyway.
Aethelwulffe, have been tempted to copy-paste before but, looking at the way code is arranged, concluded that it probably wont work. try my method referred to above if you can.
Mukoya.
zhhealthcare wrote on Saturday, March 26, 2011:
Mukoya,
To debug the issue with the image, take the view source of the frame(by right clicking) listing the uploaded file.
Search to the file name in the generated code.Adjacent to that an ‘<img src=’ should be there along with the path to the image.
Verify that the path of image is correct including the capitalization of the extension.
Here in my case iam getting the image displayed and code is as below
Scrap_Icons_1.jpg
img src=’/openemr/sites/default/documents/47/936/Scrap_Icons_1.jpg’ border=‘0’
Thanks
Paul
bradymiller wrote on Saturday, March 26, 2011:
zhhealthcare,
This isn’t working because mukoya has a secure set up likely (ie. his apache does not give him direct access to the documents directory which is important; or else anybody without even logging into openemr can fish for patient documents). Need to use the controller.php functions to send documents like this (to see examples, check out the way patient photos are sent to the user in the patient summary screen and how documents are sent in the document viewing module).
-brady
mukoya wrote on Saturday, March 26, 2011:
Thanks. Below is what i get when i view the source of the frame. The file name is “mytestimage.jpg” and i can se it was uploaded to the correct directory. Still cannot display it. windows 7, xampp 1.7.3.
Another thing i noted is that when i attempt to view this image (by clicking edit, save or delete-I think in future we should have a “view” button or preview with “enlarge” option), It opens a different “compatible” document e.g pdf, that was earlier saved by the same form for the same encounter.
<html>
<head>
<title>
OpenEMR</title>
<script type=“text/javascript” src="…/…/library/topdialog.js"></script>
<script language=‘JavaScript’>
// login.php makes sure the session ID captured here is different for each
// new login. We maintain it here because most browsers do not have separate
// cookie storage for different top-level windows. This function should be
// called just prior to invoking any server script that requires correct
// session data. onclick=“top.restoreSession()” usually does the job.
//
var oemr_session_name = ‘OpenEMR’;
var oemr_session_id = ‘misk63iah6pblhf0gjk03q3fq1’;
//
function restoreSession() {
var ca = document.cookie.split(’; ‘);
for (var i = 0; i < ca.length; ++i) {
var c = ca_.split(’=’);
if (c == oemr_session_name && c != oemr_session_id) {
document.cookie = oemr_session_name + ‘=’ + oemr_session_id + ‘; path=/’;
}
}
return true;
}
</script>
</head>
<!- border (mozilla) and framespacing (ie) are the same thing. ->
<!- frameborder specifies a 3d look, not whether there are borders. ->
<frameset rows=‘45,*’ frameborder=‘1’ border=‘1’ framespacing=‘1’ onunload=‘imclosing()’>
<frame src=‘main_title.php’ name=‘Title’ scrolling=‘no’ frameborder=‘1’ noresize />
<frameset cols=‘130,*’ id=‘fsbody’ frameborder=‘1’ border=‘4’ framespacing=‘4’>
<frameset rows=’*,0’ frameborder=‘0’ border=‘0’ framespacing=‘0’>
<frame src=‘left_nav.php’ name=‘left_nav’ />
<frame src=‘daemon_frame.php’ name=‘Daemon’ scrolling=‘no’ frameborder=‘0’
border=‘0’ framespacing=‘0’ />
</frameset>
<frameset rows=‘60%,*’ id=‘fsright’ bordercolor=’#999999’ frameborder=‘1’>
<frame src=‘main_info.php’ name=‘RTop’ scrolling=‘auto’ />
<frame src=‘messages/messages.php’ name=‘RBot’ scrolling=‘auto’ />
</frameset>
</frameset>
</frameset>
</html>
Mukoya.
_
zhhealthcare wrote on Saturday, March 26, 2011:
Issue of image not getting displayed(in high security mode) is resolved by using the controller.php page for images.
For Preview
pdf and images are displayed along with the screen.
For pdf one full page is visible, and image comes in its full size.
Button is there for pdf to save.
Image can be saved by right clicking.
For all other types of files the default style of download is followed.
Updated in git to the branch
(doc_db_to_file_correct) accessible at
https://github.com/zhhealthcare/openemr/tree/doc_db_to_file_correct
The patch file is uploaded with name
‘0002-Issue-of-image-not-getting-displayed.patch’ at the tracker
https://sourceforge.net/tracker/?func=detail&aid=3243998&group_id=60081&atid=1245239
Thanks
Paul
mukoya wrote on Saturday, March 26, 2011:
Paul,
I really appreciate your effort.
Will test and report.
mukoya wrote on Saturday, March 26, 2011:
Greeeaaat!! Thanks Paul, Brady, Aethelwolffe.
Pdf, jpg,png,gif all working great. Correct upload and display within OEMR UI.
As mentioned in pauls post, “other” files (which I guess most people wont be using much anyway) including bmp, are downloaded by the browser as usual.
Issues:
1. Once there is at least one of these “other” formats uploaded within the same encounter (yet to try on different encounters), the browser tries to download all of them whenever any one image/file is saved/edited/closed. For example i have pdf, jpg, word, txt. When saving/closing any one of the 4, e.g pdf, the browser spontaneously launches download wizard for word and txt.
2. There is no way of knowing the contents of the form when collapsed. I guess most providers will have only one or two scanned notes forms per encounter so it might not be a big issue. However, it would be great to display, say a title (like in the other similar form called “documents”, or part of the comment, more or less like in the CAMOS module.
I guess the form is more or less usable now.
Mukoya.
zhhealthcare wrote on Saturday, March 26, 2011:
Regarding issue 1, it is not an issue.
After saving it is going to the encounter display screen.In encounter display screen it is coded to display all the files.
That is why, you feel, even after saving one all are getting displayed.
You may note that this is the action when you select the encounter.The same screen is showed in both cases and all files are displayed.
You notice it as it is asking for download.If they are all images still they will be listed but we will not notice it.
Thanks
Paul
arnabnaha wrote on Saturday, March 26, 2011:
Hi…
I downloaded the zhhealthcare’s latest repository for the scanned notes…i get the following error on clicking a patient in the bottom encounter screen:
ERROR: query failed: SELECT d.id, d.type, d.url, d.docdate, d.list_id, c.name FROM documents AS d, categories_to_documents AS cd, categories AS c WHERE d.id not in (SELECT documents.id FROM documents,form_scanned_notes,forms WHERE form_scanned_notes.document_id=documents.id and forms.form_id=form_scanned_notes.id and forms.formdir=‘scanned_notes’ and foreign_id = ? and forms.pid= ?) and d.foreign_id = ? AND cd.document_id = d.id AND c.id = cd.category_id ORDER BY d.docdate DESC, d.id DESC
Error: Unknown column ‘form_scanned_notes.document_id’ in ‘where clause’
zhhealthcare wrote on Saturday, March 26, 2011:
Field document_id in the table form_scanned_notes is added by us to link with the existing document management system.
If the table form_scanned_notes was already in your system add this field at the end.Details can be found in the
\interface\forms\scanned_notes\table.sql
The total table now looks like
CREATE TABLE IF NOT EXISTS form_scanned_notes (
id bigint(20) NOT NULL auto_increment,
activity tinyint(1) NOT NULL DEFAULT 1, - 0 if deleted
notes text NOT NULL DEFAULT ‘’,
document_id bigint(20) NOT NULL COMMENT ‘Id of the documents table’,
PRIMARY KEY (id)
) TYPE=MyISAM;
Thanks
Paul
mukoya wrote on Saturday, March 26, 2011:
Paul,
Agreed. It is actually like a “refresh” Noted it also when opening the encounter.
Thanks.
arnabnaha wrote on Saturday, March 26, 2011:
Thanks Zh healthcare…
Its fixed and really working nice…great work done…
Another request….
I asked u a for an improvement in the payment module regarding automatically filling up the amount field for a particular patient in the payment module and displaying the balance due for that patient. it will be really great if that could be done. it will really increase the functionality of the payment module.
Dr. Arnab Naha