Translations for this type of thing are obviously murky and will defer to you on where it should be used. Note there is always the possibility that somebody in the US will be more fluent in another language (such as Spanish or Chinese); for example, an Acupuncture and Chinese Medicine clinic that bills to US insurance but are only fluent in Chinese (and English insurance lingo).
Would it be possible to use the libraries in public/assets instead(and drop the ones you are bringing in)? I added the libaries that you are using there in the main codebase:
It was a little tricky for me to get the jQuery libraries to all work together, which is why I ended up with what I have. It should be just a matter of changing the paths in the /interface/billing/edih_view.php as that is the only place they are used. How would I do that with my github branch?
It might be a good idea to have one set of jQuery libraries, plugins, and css all together that interact correctly because it now appears to be a hodgpodge of javascript libraries in /library/js. I found I had to use the latest jQuery DataTables because the older versions were not really available and then I had to use the more recent jQuery-UI and the jQuery it was based on. I don’t think the “latest and greatest” is the main issue with jQuery, just having the whole thing working seems more important. I’m not a javascript expert by any measure, so I could not explain why the older versions did not work or why it ended up working the way I did it. Even with “firebug” coding javascript is a total pain, IMHO.
Just let me know when you have a break in coding. I’ll then rebase your code into 1 commit on top of most recent codebase. Then you can work from that branch.
Brady, I think you should just continue with your review and change links to javascript libraries to the locations you like. Also any translations you need. This will all be in the file /interface/edih_view.php. The only thing I was wanting to change was to extend the jquery-ui dialog to add a minimize button in the titlebar, but that is taking too long and I have other things I need to do now. It is not that important for the user, but I thought it would be a nice touch and I will submit it when I finally get it done. I don’t want to hold things up for this. When I submitted the first version, you did all this for me then, too. Tie ins to the OpenEMR libraries will be in /interface/edih_main.php, but I think that is all there.
First step is to migrate to the standard assets, which I have just done. I placed the work on this branch(your work is in the top commit there and note there are no more libraries in there ):
Please test it and let me know that it is working and looking fine. After confirm that it is working, then I would be happy to help you get this project past the finish line.
Thanks for your work on this. I installed the version 2 (take 2) on my computer. It seems to work fine as far as my code goes. However, there is a grey bar across the tab interface below the tab bar which persists on all the tabs. You can see it in your demo.
There is a dialog resize problem on the New Files tab, but no dialog resize problem on the CSV Tables tab. On the New Files tab, the dialog content does not expand to the full width or height and actually shrinks with some resize efforts. On the CSV Tables tab, the dialog resizes correctly, but there seems to be a little extra padding on the left side.
The jquery-ui css looks like the default “lightness” style and not the custom one I had done. I don’t care about that, but I am mystified by the dialog resize issues. There are references to a bug in the jquery-ui dialog for the maxWidth property. In /interface/billing/edih_view.php there is a function dialogOptions(appendElem) that sets these properties and maybe that s the problem. I suspect there is some nuance in the CSS that causes the problem. Unfortunately, there are a lot of css and js files that load with OpenEMR.
I changed the jquery-ui theme to sunny which fixed the grey bar issue and the CSV Tables dialog. Let me know if the dialog is now working on the New Files tab(also let me know how I can test that dialog if it’s still not working right).
You need an x12 edi file that you have uploaded into a table. I don’t have a de-identified file, but a 277 or 835 would be the best, since they are the most used.
I found some small errors in my code and fixed them. There should be a new commit on my github. Handle newlines in x12 file scan, missed corrections for 278 type, and a few new service type code values. It should not affect what you are doing other than needing to update the files.
I installed the v6 version. It looks pretty good, but the dialog resize issue is still there on the New Files tab when the process files results are shown. It is better now, but there is probably some css conflict somewhere. Also the DataTables works better on the CSV Tables tab. I had some css rules to try and improve the appearance which may not be needed now. I did not experiment on this.
):