rachoac wrote on Thursday, January 07, 2010:
Hi Folks,
I’m continuing to contribute MI2 UI enhancements into the trunk. Haven’t checked it in yet, but if you are interested in reviewing the patch, its available here:
https://sourceforge.net/tracker/?func=detail&aid=2927425&group_id=60081&atid=1245239
As I noted there, the changes center around cleaning up overall look and feel of printed and online views. Overall the reports all look and operate the same now.
Thanks,
Aron
bradymiller wrote on Thursday, January 07, 2010:
wow,
Reading through that code made me feel like I was watching a bad movie over and over again. Code looks great and it tested well for me. I’m ok with the commit. There was a problem with two files when i applied the patch (not sure what this is, just make sure your developing on the tip - I’m guessing you are and this is just an oddity with this specific patch - maybe not used -u setting):
patching file openemr/interface/reports/collections_report.php
patching file openemr/interface/reports/charts_checked_out.php
patching file openemr/interface/reports/chart_location_activity.php
patching file openemr/interface/reports/insurance_allocation_report.php
patching file openemr/interface/reports/front_receipts_report.php
patching file openemr/interface/reports/custom_report_range.php
patching file openemr/interface/reports/prescriptions_report.php
patching file openemr/interface/billing/indigent_patients_report.php
Hunk #1 FAILED at 31.
Hunk #2 FAILED at 254.
Hunk #3 FAILED at 283.
3 out of 3 hunks FAILED - saving rejects to file openemr/interface/billing/indigent_patients_report.php.rej
patching file openemr/interface/reports/patient_list.php
patching file openemr/interface/reports/services_by_category.php
patching file openemr/interface/billing/sl_receipts_report.php
patching file openemr/interface/reports/appt_encounter_report.php
patching file openemr/interface/main/left_nav.php
patching file openemr/interface/themes/style_sky_blue.css
patching file openemr/interface/reports/receipts_by_method_report.php
Hunk #1 FAILED at 76.
Hunk #2 FAILED at 98.
Hunk #3 FAILED at 114.
Hunk #4 FAILED at 132.
Hunk #5 FAILED at 176.
Hunk #6 FAILED at 586.
Hunk #7 FAILED at 606.
Hunk #8 FAILED at 621.
Hunk #9 FAILED at 635.
9 out of 9 hunks FAILED - saving rejects to file openemr/interface/reports/receipts_by_method_report.php.rej
patching file openemr/interface/reports/appointments_report.php
patching file openemr/interface/reports/sales_by_item.php
patching file openemr/interface/reports/unique_seen_patients_report.php
patching file openemr/interface/reports/referrals_report.php
patching file openemr/interface/reports/encounters_report.php
-brady
sunsetsystems wrote on Thursday, January 07, 2010:
Thanks Aron! I don’t have time to apply the patch and test this morning, so I’ll just thank Brady also for checking it. I don’t suppose you have an online demo site?
rachoac wrote on Friday, January 08, 2010:
Thanks for the review Brady. I’ve checked the changes into the trunk.
Aron