wakie87 wrote on Wednesday, July 06, 2016:
Hi All,
As part of the modernization project I though I would start looking at deprecated code and removing it from the codebase.
Checkout first commit which removes the function html_header_show() and all references to it. It was actually commented out back in 2009.
Scott
sunsetsystems wrote on Wednesday, July 06, 2016:
Also obsolete is the layout style “Old style layout with no left menu”. You can get rid of a lot of cruft by taking that out, and it will simplify the frames logic as well.
You might also be able to get rid of the radio button style layout. I would be surprised if anyone uses it any more.
robertdown wrote on Wednesday, July 06, 2016:
This was actually discussed a while back, I just haven’t gotten to it. Deleting the radio button based navigation is a go.
osverdlov wrote on Wednesday, July 06, 2016:
Scott,
We rely on this function to bring custom assets from user defined directory. We have PR waiting.
With best regards,
Oleg Sverdlov
bradymiller wrote on Wednesday, July 06, 2016:
Hi,
Oleg’s PR is here:
Oleg is basically using the html_header_show() function as a hook to bring in custom assets, which seems reasonable.
Thoughts?
-brady
OpenEMR
mdsupport wrote on Wednesday, July 06, 2016:
Having header (and in fact footer as well) hook makes localizations less intrusive. Ideally a default header would bring in theme css and footer will bring in standard js. That makes it easier to propagate global changes e.g. jQuery version switch - not every script needs to be touched to upgrade core components.
sunsetsystems wrote on Wednesday, July 06, 2016:
You might be able to talk Scott into doing it for you. 