Removing DBC stuff

bradymiller wrote on Tuesday, June 02, 2009:

hey,

Planning to begin removal of the DBC (dutch group) stuff to ensure there are no rogue mysql calls (we need complete control of mysql calls from library/sql.inc to ensure UTF8 encoding correctly).

In globals plan to keep the globals flag there, and give warning to keep false. Will remove the call to include /library/DBC_include.php if toggle set, since this file basically set up below files, which I plan to delete all of them (nicely, I worked through all the inlcudes and this is really a very contained system and removal has caused no issues in my environment):
rm: remove regular file `openemr/library/DBC_cfunctions.php’? y
rm: remove regular file `openemr/library/DBC_cron.php’? y
rm: remove regular file `openemr/library/DBC_database.php’? y
rm: remove regular file `openemr/library/DBC_decisiontree.php’? y
rm: remove regular file `openemr/library/DBC_files.php’? y
rm: remove regular file `openemr/library/DBC_functions.php’? y
rm: remove regular file `openemr/library/DBC_include.php’? y
rm: remove regular file `openemr/library/DBC_validations.php’? y
rm: remove regular file `openemr/library/DBC_Vektis_constants.php’? y
rm: remove regular file `openemr/library/DBC_Vektis.php’? y
rm: remove regular file `openemr/interface/patient_file/encounter/dbc_aschoose.php’? y
rm: remove regular file `openemr/interface/patient_file/encounter/dbc_close.php’? y
rm: remove regular file `openemr/interface/patient_file/encounter/dbc_content.php’? y
rm: remove regular file `openemr/interface/patient_file/encounter/dbc_diagnose_as1.php’? y
rm: remove regular file `openemr/interface/patient_file/encounter/dbc_diagnose_as2.php’? y
rm: remove regular file `openemr/interface/patient_file/encounter/dbc_diagnose_as3.php’? y
rm: remove regular file `openemr/interface/patient_file/encounter/dbc_diagnose_as4.php’? y
rm: remove regular file `openemr/interface/patient_file/encounter/dbc_diagnose_as5.php’? y
rm: remove regular file `openemr/interface/patient_file/encounter/dbc_historyfull.php’? y
rm: remove regular file `openemr/interface/patient_file/encounter/dbc_history.php’? y
rm: remove regular file `openemr/interface/patient_file/encounter/dbc_showfollowup.php’? y
rm: remove regular file `openemr/interface/patient_file/encounter/as.php’? y
rm: remove regular file `openemr/library/js/add_edit_event.js’? y

Of course there are more, but this stuff seems to be the heart and will eliminate any chance of rogue mysql calls. Then can clean up other files over time.

Joe, removing this stuff doesn’t seem to affect the functionality of the Dutch forms your using.

If there is no dissent, then the DBC clean up will commence.

-brady

ideaman911 wrote on Tuesday, June 02, 2009:

Brady;

I agree, I see no way they affect the three dutch Psyche forms.  And thanks for trying to include them in the overall schema.

Pimm; you are the real expert here.  Any problems?

Joe Holzer    Idea Man
http://www.holzerent.com

bradymiller wrote on Monday, July 20, 2009:

hey,
I finally got around to removing the above files (removed in both development tip and the 3.1.0 development branch)
-brady