salamia wrote on Friday, March 12, 2010:
Hello All,
I have been working on omer for the last few months. It is has been build
very well and it has been running very smothly. Just to get myself familar
with the developement procress, I am submitting two minor changes for code review (removing
the ‘$’ symbol) from:
openemr/interface/patient_file/summary/demographics.php &
openemr/interface/patient_file/encounter/copay.php
Thanks
-Logan
bradymiller wrote on Friday, March 12, 2010:
hey,
Patches look like they will work. Why do you want to remove the $ symbols?
-brady
salamia wrote on Friday, March 12, 2010:
Thanks Brady,
Most of the places in the code, it looks like the currency does not have any symbol associated to it, other than these two places I could find. I assumed that there was an attempt to have the currency amount without any symbol next to it, and these two places got missed out. That is why I added these changes.
Thanks
-Logan
bradymiller wrote on Saturday, March 13, 2010:
hi,
We don’t want to remove the $ . On a positive note, though, you’ve created nice patches that work. Looking forward to more.
thanks,
-brady
bradymiller wrote on Saturday, March 13, 2010:
hey,
For further learning on the translation function (the xl() function), check out:
http://www.openmedsoftware.org/wiki/Development_Policies#Internationalization
So since that $ is within the xl function it gets translated to language specific symbols; check out row 3425 of the translation spreadsheet at http://spreadsheets.google.com/ccc?key=0AtTW60zHo6HzcGg0UE9JMGJHM1NsSWpuYkh0Snl4Q0E&hl=en
If we wanted to remove the $, then would want to remove the xl() function that’s wrapped around it, since don’t want to translate the " " (space) character.
-brady