Past Appts Widget in Demog ( code review)

tmccormi wrote on Thursday, November 08, 2012:

I added a configurable widget to display past appointment information.  Just the date, final status and provider. 
Can set the number of past appts to show in Globals->Features.  Zero will hide the widget.

https://github.com/tmccormi/openemr/commit/fb32d7fd1167bfc9f64734e248818e77ac7b7e6e

At some point it might be good to try and pull both appointment widgets into library/appointment.inc.php as a set of functions to reduce some code redundancy.

I did reformat some spacing in the current appointments widget, the indenting was off and hard to read.

Tony
www.mi-squared.com / @tonymi2
oemr.org / @OEMR_org

bradymiller wrote on Thursday, November 08, 2012:

Hi,
Placed review on github. Overall, looks good to me. Do these widgets show recurring appointments?
-brady
OpenEMR

bradymiller wrote on Thursday, November 08, 2012:

also,
mistakenly did review via the openemr github account, so the comments are stamped with openemr rather than bradymiller.
-brady

tmccormi wrote on Friday, November 09, 2012:

Review code fixed and push to master.

31dc32c Past Appointment Widget, Configurable in Globals Features
M       interface/patient_file/summary/demographics.php
M       library/globals.inc.php

The number of past appointments to view default to ZERO (0) therefore hiding the widget.  Edit Globals->Features tab and place a positive number there.

Tony
www.mi-squared.com / @tonymi2
oemr.org / @OEMR_org