OpenEMR API

OpenEMR Development
21

bradymiller wrote on Sunday, March 03, 2013:

Hi,
Looks like the notification is going through this:
http://developer.apple.com/library/mac/#documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/ApplePushService/ApplePushService.html
(so will want a global below your current one perhaps called something like ‘Enable Apple Push Notification Service’)
(while there, I’d rename your current one to ‘Enable mobile device REST API server?’)
-brady
OpenEMR

22

medmasterpro wrote on Wednesday, March 06, 2013:

Hi Brady,

Yes the function is sending push notifications to the user’s device using Apple Push Notification Server(APNS).

You can rename the current one to ‘Enable mobile device REST API server’. For the push notification control setting, we will add a global named ‘Enable Apple Push Notification Service’.

Thanks for your suggestions,

MedMaster

23

bradymiller wrote on Sunday, March 10, 2013:

Hi medmasterpro,

To keep things organized on the review end created a wiki page here. This is where I plan to place the review (I’ll let you know when and where I add something to it):
http://www.open-emr.org/wiki/index.php/Medmasterpro_API_Review
(more than 100 scripts/functions, wow :slight_smile: )

Hoping to begin reviewing it this week,
-brady
OpenEMR

24

bradymiller wrote on Sunday, March 17, 2013:

Hi medmasterpro,

I started the review. Check it out here:
http://www.open-emr.org/wiki/index.php/Medmasterpro_API_Review

Got through 14 of 100 scripts. Gonna take awhile (on order of months), so I suggest starting to address the things I am bringing up as we go. Recommend using the wiki for discussion/questions/issues and to keep track of issues that have been addressed. If don’t have a wiki account yet, then request it here: http://www.open-emr.org/wiki/index.php/Special:RequestAccount

thanks,
-brady
OpenEMR

25

medmasterpro wrote on Wednesday, April 03, 2013:

Hi Brady,

Thanks for review the code. We have checked your feedback on wiki and made changes in the code as you asked. We’ve posted comments on discussion page of wiki. Please review the changes and share your thoughts.

Thanks,
MedMaster

26

medmasterpro wrote on Sunday, April 21, 2013:

Hi Brady,

Please review the changes made so far and let us know about your thoughts.

Thanks,
MedMaster

27

bradymiller wrote on Tuesday, April 23, 2013:

Hi MedMaster,

Sorry for the delay. Plan to look through it over the weekend; will hopefully have a create_document function ready by then that you can use in your functions that create patient documents. Also, rather than placing your review responses on a separate wiki page, place/integrate them into the original review comments (this way it will be much easier to communicate back and forth regarding issues etc.):
http://www.open-emr.org/wiki/index.php/Medmasterpro_API_Review

-brady
OpenEMR

28

medmasterpro wrote on Tuesday, April 23, 2013:

Hi Brady,

Thank you to share your plan. We’d like to hear you on create_document() function and place our response/comments on the same wiki page for upcoming issues.

Thanks,
MedMaster

29

bradymiller wrote on Wednesday, April 24, 2013:

btw,

Here’s the preliminary function:


(the addNewDocument() function)

Note this is just preliminary; suggest not working it into your code until it’s completed and in the official codebase.

-brady
OpenEMR

30

bradymiller wrote on Monday, May 06, 2013:

Hi,

Thanks for being patient; committed the addNewDocument() function to the official codebase and began reviewing your new changes last weekend and integrated your review responses into the the original wiki page(for now on, use this page for the ongoing review). At this point , no feedback yet since just beginning to look through it. Will plan to do much more code reviewing over the next week.

thanks,
-brady
OpenEMR

31

medmasterpro wrote on Tuesday, May 07, 2013:

Hi Brady,

Thanks for update on addNewDocument() function. We’ll try to use it where needed. Thank you for reviewing changes/issues and your feedback on wiki page. We’ve already used same wiki page for our response on one issue. We’ve removed $_SESSION[‘authGroup’] variable from rest of API’s and set session variables as set in library/auth.inc script where required. Please review these change as per your plan.

Thanks,
MedMaster

32

bradymiller wrote on Monday, May 13, 2013:

Hi,

Check out the Review wiki page for some more comments (note that scripts that contain only COMPLETED are basically done with the review, while those with ACTIVE are still ongoing). Hopefully things are clear. Once these scripts are more solid (ie. get some of the fundamentals like creating documents and setting the session variables correctly), then will plan to push ahead and start going through the other scripts. Also plan to modularize things as we go, if can be done (one example of this that I have just done and committed to the codebase is the frontPayment() function; see review wiki page for details).

If you have responses to my responses on the wiki page, then make another MEDMASTERPRO RESPONSE section following mine(REVIEWER RESPONSE). I’ll be responsible for tracking/adding/modifying the action items with COMPLETED or ACTIVE.

Also, if anybody else is interested in participating in the review, please feel free:
http://www.open-emr.org/wiki/index.php/Medmasterpro_API_Review

thanks,
-brady
OpenEMR

33

medmasterpro wrote on Friday, May 17, 2013:

Hi Brady,

We have made changes in the code as per REVIEWER RESPONSE on wiki page and committed changes to repo. We’ve added MEDMASTERPRO RESPONSE under REVIEWER RESPONSE as you asked in your last comments.

Please review the changes and share your thoughts.

Thanks,
MedMaster

34

medmasterpro wrote on Wednesday, June 05, 2013:

Hi Brady,

We have added CRUD API’s of Speech Dictation for a encounter/visit. Also, we have added files names on wiki page.

Please review the changes as per your plan and share your thoughts.

Thanks,
MedMaster

35

bradymiller wrote on Monday, June 10, 2013:

Hi MedMaster,

Have noted your changes. Plan to spend some time this week and weekend (especially plan to focus on the documents issue).

thanks,
-brady
OpenEMR

36

bradymiller wrote on Monday, June 17, 2013:

Hi,

This is going to be a bit slow going for next month or so as majority of my resources will be going towards the next OpenEMR release. I am still a bit confused on the documents issue. It looks like you do have the mimetype, size, and filename coming through as parameters which you are inserting into the documents table entry. Why can’t you feed these into the following function:

addNewDocument($doc_name,$mime_type,$file,0,$filesize,$user_owner,$patient_id,$category_id)

-brady
OpenEMR

37

medmasterpro wrote on Monday, July 01, 2013:

Hi Brady,

We have used addNewDocument() function to create documents. Please review the changes as per your plan and share your thoughts.

Thanks,
MedMaster

38

bradymiller wrote on Monday, July 29, 2013:

Hi Medmaster,

Plan to start reviewing this code again after 4.1.2 release. Thanks for being patient.

-brady
OpenEMR

39

medmasterpro wrote on Tuesday, August 13, 2013:

Hi Brady,

Thank you for sharing your plan. Looking forward for your feedback after 4.1.2 release.

Thanks,
MedMaster

40

ravisoni wrote on Monday, December 23, 2013:

Hello medMaster,

I’m getting some issue while accessing the API
When I’m not logged in into the openEmr admin the API responds with “Site ID is missing from session data!”.
Do you have any solution to it, I’ve tried setting $_GET[‘site’] to ‘default’ in globals.php file to but this just opens the full site in the browser instead of API response.

Thanks Ravi