NewCrop Interface improvements

tmccormi wrote on Monday, December 09, 2013:

We are testing a pile of updates to the NewCrop interface and anticipate posting the code for the community by the end of the week. Here’s the list:

This predominately makes the sync with NewCrop faster and keeps the number of touches to NewCrop down to just the first access of the patient record in a given, configurable time to live.

Corrected value reference to SiteId to allow two databases to be used by one Prescribing EIN without mixing PIDs across them.

Corrected issue with Allergies not displaying on patient info page. Cleaned up code and naming of methods.

The rest is code and error reporting clean up.

Basic clean-up and TTL feature integration:
Adjusted placement of file inclusion.
Consolidated eRxSOAP initialization to class construct.
Refactored initialize___ functions to simplify code and added soap settings reset to each.
Added connectors configuration for eRx time-to-live feature.
Added eRx table definition to database SQL file.
Added eRx table definition to upgrade SQL file.
Added functionality to eRxStore for interactions
Corrected misreferenced method in eRxSOAP class.
Added value type conditionals to stop errors, corrected logic flow & method usage.
Corrected table erx_ttl_touch ENUM definition, in both SQL files.

I’d like to thank Sam Likins and welcome him to the mi-squared team!

Tony

bradymiller wrote on Tuesday, December 10, 2013:

Hi Tony and Sam,
Sounds great. Look forward to seeing the code.
-brady
OpenEMR

samuelelliot wrote on Monday, December 16, 2013:

Tony and Brady,

The code changes can be found at following URL:
https://github.com/samlikins/openemr/tree/samlikins_newcrop

Added NewCrop SOAP caching and implemented usage of AccountId.

  • Added common NewCrop E-Prescription class (eRxSOAP) for SOAP request caching.
  • Added common NewCrop E-Prescription class (eRxStore) for data store actions.
  • Added new eRx table definition to database & upgrade SQL file.
  • Added connectors configuration for SOAP time-to-live & NewCrop AccountId.
  • Updated eRx_xml.php to use new connector configuration for AccountId.
  • Updated soap_accountStatusDetails.php, soap_allergy.php, and soap_patientfullmedication.php to utilize new classes.

Sam

bradymiller wrote on Tuesday, December 17, 2013:

Hi,

Placed a review on github:

thanks,
-brady
OpenEMR

samuelelliot wrote on Friday, December 20, 2013:

Brady,

I reviewed your comments and have made your noted changes, as well as a few additional modifications I noticed while making the changes.

https://github.com/samlikins/openemr/tree/samlikins_newcrop_fixes

Thanks,

Sam

bradymiller wrote on Saturday, December 21, 2013:

Hi Sam,

Looks very nice. Committed your code to the codebase and followed it with a small commit to fix a couple minor issues.

Looking forward to your next contribution :slight_smile:
-brady
OpenEMR