Are these bug fixes or feature additions? They appear to be bug fixes with the change in case of Label and addition of a list, which seems like it should of been imported in first version (since that list is not in OpenEMR by default). I just want to confirm it’s a bug fix, then it makes sense to commit this as is. If it’s more of a feature add on, then would make more sense to make it a separate new form (otherwise if a user re-built the form via xmlformgen, then it wouldn’t be compatible with their old form).
Just noted that another entry was added:
The Respondent entry and a corresponding list
I’m note sure what to do here. The issue I see arising is that if a user created a form before this using this script, and then decides to re-create the form (perhaps to use more updated code) they will no longer be compatible. The new form will have an entry in it the previous forms didn’t (so, when a user prints them out, there will be a new blank entry there that never existed before). Also, at some point in time, there will likely be a process to run these forms directly from xml script (ie. no need to create the php files). Does anybody have any thoughts here? I’d hate to force the creation of a new history_form just to add one new item entry.
Completely disregard. my blabbering. It looks like the respondent entry was already there previously, so the lists are fine. I will commit it as is to sourceforge.