New report shows in a popup window instead of the right side frame

system · August 6, 2015, 2:06am

merlinsilk wrote on Thursday, August 06, 2015:

I am getting my feet wet with real code changes and one of the first things I did is create a new report under Reports > Clients that is very similar to the ‘List’ but gives me mostly the patient name and email address.
All that worked well as I more or less duplicated the functionality of the existing ‘List’ but I am surprized that my new report shows in a separate popup window instead of in the main screen on the lower right.
What am I missing - is there a separate place where I can tell what wiindow pops up and which does not?
Thanks,
Merlin

system · August 6, 2015, 2:42am

yehster wrote on Thursday, August 06, 2015:

Most likely the difference is using genMiscLink vs. genPopLink in the left_nav.php changes.

github.com

openemr/openemr/blob/master/interface/main/left_nav.php#L1552


        <?php if (acl_check('admin', 'users')) {
            genMiscLink('RTop', 'adm', '0', xl('Certificates'), 'usergroup/ssl_certificates_admin.php');
} ?>
        <?php if (acl_check('admin', 'super')) {
            genMiscLink('RTop', 'adm', '0', xl('Native Data Loads'), '../interface/super/load_codes.php');
} ?>
        <?php if (acl_check('admin', 'super')) {
            genMiscLink('RTop', 'adm', '0', xl('External Data Loads'), '../interface/code_systems/dataloads_ajax.php');
} ?>
        <?php if (acl_check('admin', 'super')) {
            genMiscLink('RTop', 'adm', '0', xl('Merge Patients'), 'patient_file/merge_patients.php');
} ?>
        <?php if (acl_check('admin', 'super')) {
            genMiscLink('RTop', 'adm', '0', xl('Import Holidays'), '../interface/main/holidays/import_holidays.php');
} ?>
        <?php if ($GLOBALS['enable_auditlog_encryption']) {
            genMiscLink('RTop', 'rep', '0', xl('Audit Log Tamper'), 'reports/audit_log_tamper_report.php');
} ?>
    </ul>
  </li>
</ul>

github.com

openemr/openemr/blob/master/interface/main/left_nav.php#L1574


  <?php } ?>


<li><a class="collapsed" id="repimg" ><span><?php xl('Reports', 'e') ?></span></a>
  <ul>
              <?php
              $module_query = sqlStatement("SELECT msh.*,ms.obj_name,ms.menu_name,ms.path,m.mod_ui_name,m.type FROM modules_hooks_settings AS msh LEFT OUTER JOIN modules_settings AS ms ON
                                  obj_name=enabled_hooks AND ms.mod_id=msh.mod_id LEFT OUTER JOIN modules AS m ON m.mod_id=ms.mod_id
                                  WHERE fld_type=3 AND mod_active=1 AND sql_run=1 AND attached_to='reports' ORDER BY mod_id");
              if (sqlNumRows($module_query)) {
                  $jid = 0;
                  $modid = '';
                  while ($modulerow = sqlFetchArray($module_query)) {
                      $modulePath = "";
                      $added      = "";
                      if ($modulerow['type'] == 0) {
                          $modulePath = $GLOBALS['customModDir'];
                          $added      = "";
                      } else {
                          $added      = "index";
                          $modulePath = $GLOBALS['zendModDir'];
                      }

system · August 9, 2015, 12:38am

merlinsilk wrote on Sunday, August 09, 2015:

Thank you so much, Kevin!