Moving OpenEMR towards HTML5 compliance

OpenEMR Development
1

ritwikg wrote on Saturday, July 26, 2014:

I edited some files to be compliant with HTML5, fixed some minor errors, and replaced Bootstrap 2.3.2 with Bootstrap 3.2.0. The GitHub pull request can be viewed at: Moving towards HTML5 compatibility by RitwikGupta · Pull Request #22 · openemr/openemr · GitHub

Could other developers validate my edits so the pull request can be merged? Thank you.

2

bradymiller wrote on Monday, July 28, 2014:

Hi Ritwik,

I placed a code review on github.

thanks,
-brady
OpenEMR

3

ritwikg wrote on Wednesday, July 30, 2014:

Hey Brady,
I acted on your code reviews and left you a comment detailing the commit

4

bradymiller wrote on Thursday, July 31, 2014:

Hi Ritwik,
Sounds great. It’s at the top of my review queue (I’ll likely review and commit it to the main codebase this weekend).
-brady
OpenEMR

5

bradymiller wrote on Friday, August 01, 2014:

Hi Ritwik,
Placed another review comment (something I noticed on testing) on github.
-brady
OpenEMR

6

ritwikg wrote on Friday, August 01, 2014:

Hey Brady,
I fixed the error with the upper right hand box. I had just misplaced a line of code. Everything looks exactly the same as the Dev Demo now.

Thanks,
Ritwik

7

bradymiller wrote on Sunday, August 03, 2014:

Looks good. i just brought your code into the official codebase (note I rebased all your commits into one). Thanks for the contribution!

-brady
OpenEMR