bradymiller wrote on Thursday, October 27, 2016:
Hi,
Here’s PR that converts the login page to pure html5/bootstrap and uses the new logo:
Demo is here:
http://www.open-emr.org/wiki/index.php/Development_Demo#192.168.1.131
Thanks to Robert to doing the majority of this work!
Requesting review.
thanks,
-brady
OpenEMR
sunsetsystems wrote on Friday, October 28, 2016:
One thing this reminds me of is the need to have some standards for specifying font sizes and other dimensions. This PR mostly specifies them as hard-coded pixels with arbitrary fixed numbers.
It seems wise to work towards the ability for a user to specify a “main” font size and derive all font sizes from that. Also I would like to see other dimensions derived from either font size or window size, never as pixels.
I don’t have all the answers but would like to see some discussion around this.
bradymiller wrote on Friday, October 28, 2016:
Hi Rod,
This PR basically removes most of the login.css styling and only adds a couple of items via px(which are involved in the placement of graphics and logos) and uses a font size relative (120%), so I think you mean our general standards of styling(for example, the standard style themes do make heavy use of fixed font sizes and px).
This is a good general discussion to have and I am interested to see input from the styling gurus (ie. Robert).
In order to keep things moving forward, though, don’t plan to address it on this focused commit (if that is ok, of course).
thanks,
-brady
bradymiller wrote on Saturday, October 29, 2016:
Hi,
Just brought in this commit to the codebase(the new login screen and logo). Also brought in a commit to remove unused logo files and a commit to add a new favicon.
-brady
OpenEMR