Layouts - Buttons added at the top

visolveemr wrote on Friday, May 27, 2016:

Hi Brady,

In the Administrator -> Layouts screen, the following buttons are available only at the bottom of the page:

  • Save Changes
  • Delete
  • Move To

Since most of the Layouts have many number of fields and the users have to scroll till the end of the page to perform the save and other functions. For easy usability, we have added the same buttons on the top as well and commit the code.

Here is the commit link: added save button in top of layout based forms · visolve-openemr/Openemr_features_enhancements@3be089f · GitHub

This items has been tracked as Feature-request #130.

Please do review and let us know.

*Thanks
OpenEMR Customization/Support Team,
ViSolve Inc

bradymiller wrote on Saturday, May 28, 2016:

Hi,

This looks good with the older themes, but the layout of the buttons(and other items on that screen) is confusing with the new default theme style_light.css. Will ask Robert to take a look at it.

-brady
OpenEMR

mdsupport wrote on Saturday, May 28, 2016:

Wouldn’t it be better to use overlapping div tags to keep existing buttons floating at the top?

sunsetsystems wrote on Saturday, May 28, 2016:

True that you could use a position:fixed div to keep the buttons onscreen as the rest of the form scrolls. This could be at the top and also contain the layout selector and “Add Group” button for compactness.

That said, what goes in depends on what developers are willing to do. :slight_smile:

Rod
http://www.sunsetsystems.com/

sunsetsystems wrote on Saturday, May 28, 2016:

Also on this topic of fixed headers, see this which may be something to leverage:

https://sourceforge.net/p/openemr/discussion/202506/thread/18f6671c/

Rod
http://www.sunsetsystems.com/

visolveemr wrote on Friday, June 03, 2016:

As discussed, we have placed the buttons as fixed on screen as the rest of the form scrolls.

Here is the commit link: fixed save button in layout header · visolve-openemr/Openemr_features_enhancements@e0ba32e · GitHub

Please do review and let us know.

Thanks
OpenEMR Customization/Support Team,
ViSolve Inc

bradymiller wrote on Friday, June 03, 2016:

Hi Visolve,

This is really neat!
Recommend:

  1. Removing the buttons at the bottom(no longer needed).
  2. Bringing in the background color from the selected stylesheet (maybe the inclusion of an additional standard class that already exists that will bring in the correct background color for the selected style?).
  3. Getting it to look acceptable with the current default style, which is style_light.css(note all the buttons/labels are out of order).

-brady
OpenEMR

sunsetsystems wrote on Friday, June 03, 2016:

Looks nice! Why does style_light move the buttons? That looks more like a bug in the theme.

I agree that the buttons at the bottom can be removed.

Rod
http://www.sunsetsystems.com/

mdsupport wrote on Friday, June 03, 2016:

This is not meant to pile on ViSolve for touching the code but more of a general design guideline suggestion:

Let CSS do the background colors for alternating rows in tables. Good bye IE8.

sunsetsystems wrote on Friday, June 03, 2016:

The problem with the theme seems to be it has float:left for buttons. Why is that? In this case adding the following to the local stylesheet fixes it (note using float also changes display, so that has to be fixed too):

input[type="button"] {
 float:none;display:inline;
}

Rod
http://www.sunsetsystems.com/

robertdown wrote on Friday, June 03, 2016:

I will look into this further.

For alternating colors on table rows, please use CSS based classes, .even and .odd

I will be updating the style_light theme to use the :nth-child(even) and :nth-child(odd) pseudo-selectors to better handle tables that may not have those classes.

Also, if making changes to the style_light theme, it would appreciated it the changes come back to me so I can update the style_light repo and SASS files respectively.

bradymiller wrote on Sunday, June 05, 2016:

Hi,

Would it make more sense to fix this in the theme (guessing it will cause issues in other places also)?

-brady
OpenEMR

sunsetsystems wrote on Sunday, June 05, 2016:

I expect so. My CSS snippet is just to show the cause and effect in this case.

Rod
http://www.sunsetsystems.com/

bradymiller wrote on Sunday, July 03, 2016:

Hi,

I just committed Visolve’s most recent code for this feature into the codebase. Thank you for the nice contribution.

-brady
OpenEMR