teryhill wrote on Wednesday, April 27, 2016:
SQL-Ledger has been removed. Now is anyone using the Athletic Team section of OpenEMR or can it be removed. Rod has states that he thought it could be removed.
Terry
bradymiller wrote on Wednesday, April 27, 2016:
Hi,
If Rod is ok with it, then agree it can be removed.
-brady
teryhill wrote on Saturday, May 07, 2016:
Here is the link to the removal of the code
bradymiller wrote on Tuesday, May 10, 2016:
Hi,
Placed a review on github.
-brady
OpenEMR
bradymiller wrote on Tuesday, May 10, 2016:
Hi Rod,
Was hoping you could take a look at this to ensure removing this stuff is ok (and to possibly point towards other athletic team code that Terry may of missed).
thanks,
-brady
OpenEMR
sunsetsystems wrote on Tuesday, May 10, 2016:
I added a couple of comments, otherwise looks good. Nice to see this cleaned up.
sunsetsystems wrote on Tuesday, May 10, 2016:
Cool. Now if you can put it all in one commit based on current code. 
Thanks,
Rod
http://www.sunsetsystems.com/
bradymiller wrote on Tuesday, May 10, 2016:
Hi,
One of the nice things about the github pull request mechanism is that it is linked to the branch that is being reviewed. This then allows Terry to address issues and fix the code within the same pull request by creating another commit(the pull request automatically changes the code in the ‘Files Changed’ tab whenever a new commit is added to the branch). So, the developer can go through multiple code review revisions on one github pull request. It makes things much more efficient and we should be recommending all developers to do this for code reviews in the future(Matrix has also been doing this which makes the code reviews go more smoothly).
When the code on the pull request is ready, it may make sense for the code integrator to rebase the commits into 1 and bring it into the OpenEMR codebase(unless of course the code is based on very old outdated code or on a branch with “dirty” merge commits; the integrator should not be responsible for merge conflicts, weeding through “dirty” merge commits, etc.).
In this case, this should just be a simple rebase. I can do it this evening if somebody doesn’t do it before then.
-brady
bradymiller wrote on Wednesday, May 11, 2016:
Hi,
Just committed Terry’s code. Thank you Terry for yet another super contribution.
-brady
OpenEMR
osverdlov wrote on Monday, June 27, 2016:
There is a lot of code validating rights to access to “squad”.
Perhaps this functionality can be reused in situations where we want to restrict access of users to patients data?
sunsetsystems wrote on Monday, June 27, 2016:
That may be reasonable, especially if it doesn’t fit to group patients by facility. A squad is a collection of patients.