bradymiller wrote on Sunday, July 08, 2012:
Hi,
Commit in above post looks good after extensive testing, so just committed to sourceforge. Can now set whether a code_type should be included in claims (Administration->Lists->‘Code Types’->‘Claims column’
-brady
OpenEMR
mcaloon wrote on Thursday, July 12, 2012:
Hello,
Just committed the rework of the External data load utility. You can check it out at https://github.com/mcaloon/openemr/commit/bbbca6a2d6ee540b7c36916dcc4125e6f59d4cd5.
Mac
mcaloon wrote on Thursday, July 12, 2012:
One other item is that I didn’t spend any time on was integrating this new page with the existing stylesheets. I was planning on getting back to this sometime unless someone else who’s familiar with the openEMR themes might pick it up. 
Mac
arnabnaha wrote on Thursday, July 12, 2012:
Hi…
Was testing your code…After clicking on the External data Load in let nav…I got a list of codes like ICD9, ICD 10 etc. After clicking on ICD 10, I got the following error:
Staged Releases
ERROR: query failed: SELECT DATE_FORMAT(`revision_date`,’%Y-%m-%d’) as `revision_date`, `revision_version`, `name`, `file_checksum` FROM `standardized_tables_track` WHERE upper(`name`) = ‘ICD10’ ORDER BY `revision_version`, `revision_date` DESC
mcaloon wrote on Thursday, July 12, 2012:
Hello arnabnaha,
This code is part of the 4.1.1 release so I had coded the upgrade script accordingly. If you run the upgrade to the 4.1.1 release I am pretty sure you’ll bypass that error.
Mac
mcaloon wrote on Thursday, July 12, 2012:
in the browser enter
<your host>/sql_upgrade.php
then pick 4.1.1 release
mac
arnabnaha wrote on Thursday, July 12, 2012:
Hi Mac…
I am already on 4.1.1 and i did a sql_upgrade before using the data load feature…but it still showed that error message…
mcaloon wrote on Friday, July 13, 2012:
Hello Arnabnaha,
I did have a missing attribute in the database.sql file for the file_checksum but i don;t think this would affect you as you ran the upgrade script. I did commit that fix tonight. I then took a fresh copy of my github branch and reinstalled the app on my test system and cannot reproduce the problem you have encountered. Could you review/post the ddl for the standardized_track_table? There is a new attribute file_checksum that should be in the table. There must be something different is our two trees causing the error.
Gitmasters: what’s the easiest way to diff my tree to arnabnaha’s?
Mac
Mac
mcaloon wrote on Friday, July 13, 2012:
Arnabnaha,
Could you post the steps you took to integrate my commit to your tree?
Mac
mcaloon wrote on Friday, July 13, 2012:
Arnabnaha,
I figured out how to compare your my_emr tree to my commit 81ab34a tree. I don’t see the code referenced yet but still poking around.
Mac
bradymiller wrote on Friday, July 13, 2012:
Hi Mac,
Placed a code review on your commit. There are lots of minor things involving translations, html escaping, etc… I have compiled all of your commits to date on top of the most recent codebase here:
commit: http://github.com/bradymiller/openemr/commit/42978e75d99b054ae9cf6c48720713ea0f02f89a
branch: http://github.com/bradymiller/openemr/commits/mcaloon-ICD10-databaseLoadCode_7
(Work from this branch for now on)
Don’t start coding from the review yet. Let me see what I can do over the next couple hours (Am trying to get this code out as quickly as possible so can move on to the next step of the release).
-brady
OpenEMR
mcaloon wrote on Friday, July 13, 2012:
Brady,
Too late, I have the ajax and list_installed fixes done…
Mac
mcaloon wrote on Friday, July 13, 2012:
just posted ajax and list install to the hub… signing off
Mac
bradymiller wrote on Friday, July 13, 2012:
hi,
awesome. btw; the interface rocks. almost done with translation incorporation into everything (including the README howtos).
-brady
bradymiller wrote on Friday, July 13, 2012:
Hi,
Here’s the updated commit in all of its glory (this contains everything in one commit and I even added the CMS ICD9/10 zip files in it). Please test/review it:
http://github.com/bradymiller/openemr/commit/ca290273e52644f029883d5bcad04c7fad154307
Mac, if you want to see what changes I made to your stuff, can see it here:
http://github.com/bradymiller/openemr/commit/442bb9ea68891995533c2698e72ef66c095788f2
To continue working on this, work from the following branch:
http://github.com/bradymiller/openemr/commits/external-database-import_1
(let me know if you need instructions on how to get this branch into your repo)
Things still left to do:
1. Throughly test SNOMED/RxNorm
2. Issues with tables:
–Why are icd10_dx_order_code and icd10_pcs_order_code not using SERIAL on the dx_id and pcs_id columns like the rest of the tables?
–Ensure community buys into creating these 12 mysql tables to support ICD9/10 in this fashion (I am convinced)
–Some comments in the tables may help (especially the active/revision columns)
3. Think about starting a wiki page to document this stuff (especially the active/revision mechanism) and begin a howto
For tester, after you import the ICD10 database, can turn on ICD10 coding at Administraiton->Lists->Code Types.
-brady
OpenEMR
arnabnaha wrote on Friday, July 13, 2012:
Hi Mac…
I just used a very raw and time consuming method…I downloaded your Github branch as ZIP, then changed the individual fils/directories by copy paste method into the official openemr 4.1.1 codebase downloaded directory…Then ran the setup.php to install a fresh database and did a fresh install of the system… Then tested your work in that fresh install….which showed those error…
Dr. Arnab Naha
mcaloon wrote on Friday, July 13, 2012:
Brady/Arnab,
I think it would a good exercise for me now that I’ve posted the commits to my branch to be able to synchronize my repo with the latest set of changes that will be in the next release. I believe you listed it above. Right now if I look at my branch it is 64 commits ahead of the point whereas Arnab’s branch is only 6 commits ahead. We know Arnab has done a manual update of his “live installation” from my stuff but I was wondering whether both of us need to do some sort of git merge or other operation to get synced up properly. We know Arnab is running into the database error when he’s using the code and I suspect something was left out during the manual intervention For me, I always run my test system out of the same directory that I cloned (e.g. my branch). So at any point if I did a git diff I can see what my changes are in my test system. I am at the outer limit of my git experience and could figure it out but want to know if you (Brady) could explain in a subsequent post how you would go about getting 2 things accomplished:
1.) Assuming Arnab is running from his “my_emr” branch (as I described I do above) I think it makes sense to sync that branch to the merged ICD10-Integration (my branch) which you listed above. I don’t know if Arnab can do that based on what he’s doing in his branch. Arnab let us know what is in your branch and whether it’s time to sync with the tip of the next release.
2.) I want to refresh my repo to the tip of the next release.
Mac
bradymiller wrote on Friday, July 13, 2012:
Hi Arnab,
This commit should work (note it comes with the ICD9/ICD10 zip files placed in their proper contrib directories):
http://github.com/bradymiller/openemr/commit/ca290273e52644f029883d5bcad04c7fad154307
-brady
OpenEMR
bradymiller wrote on Friday, July 13, 2012:
Hi Mac,
Copy/paste contents of you .git/config file to my email address at brady@sparmy.com . Then can give you commands to:
1)Update your master to most recent codebase
2)Create a branch to hold the most current external database import commit
-brady
OpenEMR