FIXED: The pdf output problem in the patient report

arnabnaha wrote on Wednesday, October 29, 2014:

Hello…
The pdf output issue which was previously present while printing patient report has been fixed by TERRY HILL.

The Pdf output previously used to get cropped irrespective of the amount of data in the encounter forms. Now after the code changes made by terry Hill, the issue has been resolved. It now displays the pdf content very nicely.

The code changes are here:

In this commit made by me, I would like to say that few xmlformgen forms report.php file has been changed by terry here as I already had the forms installed, to make them work nicely.

The other forms work very efficiently with pdf output now. I have tested them thoroughly.

Terry is working on the mechanism of correcting the xmlformgen formmaker, so that it automatically fixes the code while makin the form from the xml file.

Thank you everyone and thanks and full credit to Terry for this awesome work. Thank you so much Terry for making my life even simpler.

arnabnaha wrote on Saturday, November 01, 2014:

I would request developers to test this code and commit in official codebase to fix this pdf issue.

bradymiller wrote on Monday, November 03, 2014:

Hi,

I placed a code review on github.

-brady
OpenEMR

arnabnaha wrote on Monday, November 03, 2014:

Hi Brady…
Will make the desired changes and already told terry to check on the questions you raised in the commit. I have tested it and printed many reports with it. It works fine and dont break any of the features of openemr. will test it further after your suggested changes are made. Thanks for reviewing it.

arnabnaha wrote on Monday, November 03, 2014:

Made the changes with terry’s help as per Brady’s Comment. By Mistake made two commits…sorry for that.

Commit 1 link: The changes as per brady's comment made by Terry for the pdf output o… · arnabnaha/openemr@beb93cb · GitHub

commit 2 link:

Thanks

bradymiller wrote on Thursday, November 06, 2014:

Hi,

The first commit has issues since following things have been edited which do not exist in the official codebase:

#	deleted by us:      interface/forms/communication/report.php
#	deleted by us:      interface/forms/followup/report.php
#	deleted by us:      interface/forms/gensurvey/report.php
#	deleted by us:      interface/forms/giexam/report.php
#	deleted by us:      interface/forms/history/report.php
#	deleted by us:      interface/forms/labs/report.php
#	deleted by us:      interface/forms/respexam/report.php
#	deleted by us:      interface/forms/urt/report.php

Are any of the above items in the official codebase? Just let me know since need to figure out how to bring in the commit in the future.

Also, xl_list_label() has not been addressed (in addition to the wordwrap was removed from it in commit 2 above):

-brady
OpenEMR

arnabnaha wrote on Thursday, November 06, 2014:

Hi…brady
will make a fresh new branch for the changes. The first commit seems to be of issue because its for my modification in my emr forms…sorry about that.

arnabnaha wrote on Monday, November 10, 2014:

Hi Brady
The fresh commit as per the official codebase recent code without my_emr modification is here

This is new branch pulled from the official codebase for making the changes as per your comment. Sorry for the bit of delay.

Regards
Dr. Arnab Naha

arnabnaha wrote on Monday, November 10, 2014:

Hi Brady…
The header and footer in the pdf output overlaps with the main text in the pdf report after the previous commit. This commit re-positions the header and footer to the right side of the pdf page to avoid the overlapping. Kindly consider it in the review.

arnabnaha wrote on Wednesday, November 12, 2014:

The modifications done as per kevin’s comment in github.
The commit is here

Please review

arnabnaha wrote on Sunday, November 16, 2014:

Hi Brady…any take on this?

bradymiller wrote on Monday, November 17, 2014:

Hi,

It looks good and I just committed it to the official codebase(note I rebased the 3 commits into 1 commit). Thanks for the contribution Arnab and Terry.

-brady
OpenEMR

arnabnaha wrote on Tuesday, November 18, 2014:

Thank you so much Brady for the commit. There is a missing double quote in the custom_report file in the commit, so placing a minor fix here. please push it too to the codebase.

bradymiller wrote on Wednesday, November 19, 2014:

I just committed your fix.
thanks,
-brady
OpenEMR

arnabnaha wrote on Wednesday, November 19, 2014:

Thank you Brady