zhhealthcare wrote on Monday, May 10, 2010:
Chris
IS there any update on the progress of this feature.
anonymous wrote on Monday, May 10, 2010:
Preliminary tests were a little flaky, working out kinks.
anonymous wrote on Tuesday, May 11, 2010:
All,
We have finished preliminary coding for the ability to add billing notes on a per invoice basic (instead of per patient). We will switch this to adding the ability. But you can at least test the functionality. We plan on moving it to within the invoice posting page and having another button that will be to add the note to the invoice and just keep the current billing note per patient the same… should have that by tomorrow.
You can also test the ability to edit/delete transactions.
Public demo is at: http://dev.ehrlive.com/public/openemr
Let me know your thoughts/suggestions.
Chris
www.ehrlive.com
sraj49 wrote on Tuesday, May 11, 2010:
The feature is great and it is good to have note per invoice which is very essential for follow-up actions. With the added button it will be great. I am waiting for this feature.
Thanks Chris.
Raj
anonymous wrote on Thursday, May 13, 2010:
Development for this is pretty much done. You can test the functionality here: http://dev.ehrlive.com/public/openemr
Let me know your opinions.
-Chris
www.ehrlive.com
sraj49 wrote on Friday, May 14, 2010:
Chris,
I have tested. I really like it. This is a much needed function to take care of clerical error which is common in any data entry.
Raj
jcull wrote on Thursday, June 03, 2010:
Hi Chris,
I liked the feature you have built to add Edit/Delet in EOB. When I looked at the code review I see your changes you have proposed in sl_eob_invoice. There are two more php files referred there…
1 sl_eob_invoice_edit.php and
2 sl_eob_patient_note.php
They seem to be new files. Is there any other place inb source forge wgere I can find these files. I appreciate the addition of this feature and would be helpful if you can upload the two missing files.
Thanks
sunsetsystems wrote on Monday, June 14, 2010:
I don’t see a tracker item or reviewable patch available for either of these new features. Where can we find them?
stephen-smith wrote on Monday, June 14, 2010:
Yes, please share!
bradymiller wrote on Monday, June 14, 2010:
it’s here:
http://sourceforge.net/tracker/?func=detail&aid=3006253&group_id=60081&atid=1245239
Note per my previous comment on the tracker that the patch needs to be redone.
-brady
sunsetsystems wrote on Monday, June 14, 2010:
Yeah some immediate problems with this patch:
- The new code has DOS/Windows line endings, which is why it replaces the whole file.
- sl_eob_invoice_edit.php seems to be new but is missing.
- sl_eob_patient_note_billing.php seems to be new but is missing.
anonymous wrote on Tuesday, June 15, 2010:
Rod and Brady,
Yes, my programmers code using dreamweaver and xampp on a windows box. I made that diff on a linux box by using the base openemr 3.2 and the modified openemr directory. Which is why I was scratching my head as to why the diff patch wasn’t being produced properly.
How can I create a diff without it replacing the whole file?
-Chris
www.ehrlive.com
sunsetsystems wrote on Tuesday, June 15, 2010:
man fromdos
or
man dos2unix
In Ubuntu the fromdos utility is in the “tofrodos” package.
sunsetsystems wrote on Saturday, July 10, 2010:
While waiting for this, a client has required the ability to delete payment and adjustment items, so I went ahead and created a patch for that. The patch also provides the ability to reset the count of statements previously printed for the invoice. Sorry for the duplicated effort, but it could not be avoided. The tracker item with the patch is here:
https://sourceforge.net/tracker/?func=detail&aid=3027828&group_id=60081&atid=1245239
Chris if you can find the time to locate the rest of your stuff and merge it in that would be great, otherwise I’ll wait for some feedback and then commit what I have if there are no objections.
anonymous wrote on Thursday, July 22, 2010:
Hey guys,
I just reposted the patch with the missing files. Give it a try and let me know if it’s good. I also did the dos2unix conversion.
Sorry it took so long to get to… but time is devoted to paying clients first.
-Chris
www.ehrlive.com
bradymiller wrote on Thursday, August 05, 2010:
Rod,
Do you plan still plan on migrating your patch to 4.0? Then can try to merge Chris’s into that.
-brady
sunsetsystems wrote on Thursday, August 05, 2010:
Hmm. Chris’s patch still seems to be missing the new scripts.
OK I’ll plan to migrate mine.
zhhealthcare wrote on Friday, August 06, 2010:
Guys
We have completed the payment system and have posted it on : http://github.com/zhhealthcare/openemr/tree/paul-payment
You are welcome to review it and comment.
sunsetsystems wrote on Friday, August 06, 2010:
What’s new/changed? Do you have a patch file?
bradymiller wrote on Friday, August 06, 2010:
hey,
What is this commit for? :
http://github.com/zhhealthcare/openemr/commit/d5a93b7e42f15147b8b206b8a6650b9cb35a36ad
What is this commit for?:
http://github.com/zhhealthcare/openemr/commit/887925371fcf525f388b9fcc5adb389862e2ffea
What is this commit for?:
http://github.com/zhhealthcare/openemr/commit/17d07246902e882c04bae8f7af8f78757b1697cd
Please check out this tutorial on github, which will then allow you to keep branches that are easily tested/committed by other git developers:
http://www.openmedsoftware.org/wiki/Git_for_dummies
Also, recommend not placing your running instance of OpenEMR within your git repository. Otherwise you end up inlcluding your settings (such as sqlconf.php file) within the commits. Better to have a script that moves the current git branch to the web directory for testing:
ubuntu sample script:
http://gist.github.com/478814
mandriva sample script:
http://gist.github.com/478787
For some reason your branch is also adding/replacing a bunch of user manual images. Is this supposed to be happening?
When above is dealt with, then it’s very straightforward to also make a patch (for the few that aren’t on github yet, Rod…) with command
git diff master..paul-payment > file.patch
My glimpse of your code looks good, but when above are dealt with, then it’s much easier for us to test and look at your code.
thanks,
brady