Demographics (MU2) Review

jansta23 wrote on Thursday, March 13, 2014:

Let me know if this is any better:

blankev wrote on Thursday, March 13, 2014:

Abganistan, Tibetan and Chinese (may be more) are still in need of alphabetical order.

I wonder if anybody still speaks medieval Dutch ;-))

The Decline option seems to be a nice extra, for compliance with the MU2.

DELETED paragraph…
Sorry here I confused Ethnicity and Race…

blankev wrote on Thursday, March 13, 2014:

V4.1.2 Looking in Demo version:

It might be good to bring Interpreter field up towards just under Language, for cosmetics.

Could also be a if then field. If only medieval Dutch is spoken the interpreter will be:any name and tel or e-mail the actual field length is now 20 char. (… my grand fathers, grandfather… ;-)) …)

Also the languages you include from the old version like Deaf etc, have probably to put in the correct place for sort order.

bradymiller wrote on Monday, March 24, 2014:

Hi Jan,

Placed a review on github:
https://github.com/jajalla23/openemr/commit/ca357042d80bbcf12dee02677c17196b4fc7b29b

Look forward to next revision.

thanks,
-brady
OpenEMR

jansta23 wrote on Wednesday, April 02, 2014:

i have completed the code changes (without upgrade script and database script) based on the review for demographics

jansta23 wrote on Thursday, April 03, 2014:

Changes for database script completed.

blankev wrote on Sunday, April 06, 2014:

Strange things have happened in OpenEMR Demographics in history perspective. There is a long list hard coded for State(s), USA states to be precise. There is very a short list with names of Other and USA, and these two are stored in LIST => Country => Other or USA.

The name of the Country in Employer Country is named geo_country_reference, is stored in List => Country => Option_id and title (USA USA)

During an earlier proces the link with the geo_country_ reference is found back in List_options for the name of the Employer country, but does not make use of the Long list of Country names in geo_country_reference table.

The above mentioned observation is being corrected with the work of Jan Jajalla?

bradymiller wrote on Sunday, April 06, 2014:

Hi Jan,

I rebased your code into one commit and reviewed it here:
https://github.com/bradymiller/openemr/commit/27b7900ee5fe6369c8cf9fe54f1385210af39a36

Look forward to next revision. (btw, this has probably turned into one of the most complicated database modification changes, so thank you Jan for the persistence to see this thing to the end :slight_smile: )

-brady
OpenEMR

bradymiller wrote on Sunday, April 06, 2014:

Hi,
Jan’s work includes bringing in a standardized language list required for MU2. Is not bringing in a list of countries. Not sure if the geo_country_reference is even being used. Here’s a link to work that begins to trace this table and whether it is actually used anywhere:


-brady
OpenEMR

jansta23 wrote on Friday, April 18, 2014:

checked in changes based on the review:

1: application changes

2: database.sql changes to support backup list

3: database upgrade script

jansta23 wrote on Friday, April 18, 2014:

heh… no problem, it was alot of fun working on these changes. Learned quite a few things in the process as well.

bradymiller wrote on Sunday, May 04, 2014:

Hi,

I rebased Jan’s work into one commit (and on top of most recent codebase) here to allow a code review (please feel free to review the code):

Also can be tested on the following “up for grabs” demo:
http://www.open-emr.org/wiki/index.php/Development_Demo#192.168.1.134

-brady
OpenEMR

blankev wrote on Sunday, May 04, 2014:

No intention to be impatient… ;-((, and reading all efforts that are done and still need to be done,) I want to ask:

Any intentions/indication of timespan to add:

New Document templates
Track anything
And MU2 Demographics

in a new patch or a new version?

Is there a rush to make the WIKI pages on Track anything for latest patch or should it be under Version 4.1.3 (Future version?)

blankev wrote on Sunday, May 04, 2014:

(1) OMB accepts the following recommendations concerning reporting more than one race:

When self-identification is used, a method for reporting more than one race should be adopted.

The method for respondents to report more than one race should take the form of multiple responses to a single question and not a “multiracial” category.

When a list of races is provided to respondents, the list should not contain a “multiracial” category.

Based on research conducted so far, two recommended forms for the instruction accompanying the multiple response question are “Mark one or more …” and “Select one or more…”

As far as Race and Ethnicity goes this is in place! Great work done. For Race there is also the option to ask the question more than once and the self conscious client can give multiple race ancestors and this is recorded as separate races as recommended in above MU2 explanations.
Just press CTRL and Click the Race (s) this will give all choices in Report, and Ethnicity can only be Hispanic/Latino and NOT also Non-Latino etc… so this can’t be clicked for more than one option.

(What else need to be tested in Demographics? Papiamentu our local language is not included, but I suppose this language is not in the official Language tables of your US-Government)

bradymiller wrote on Tuesday, May 06, 2014:

Hi,
Very unlikely that these items will get into a patch; ie. will need to wait for next version release.
-brady
OpenEMR

blankev wrote on Tuesday, May 06, 2014:

Except for the MU2 stage there seems to be no rush. The WIKI pages on using the Demo versions latest developments seem to be updated and in no need to change anything. Please tell me if these also need some corrections to include.

Next weeks I might have some time to create Track Anything WIKI-page if it is not created by others.

Tnx for the info!

bradymiller wrote on Wednesday, May 07, 2014:

Hi,

To help with testing/review and incorporation of this code into the codebase, I broke up the code into three commits here:
https://github.com/bradymiller/openemr/commits/jajalla-MU2-demographics-organization-code_1

If tests well and no issues on review, then guessing the first two commits will be ready for commit. Although I haven’t yet reviewed in detail, guessing the third commit (that brings in a new language list) will still require some more minor work.

-brady
OpenEMR

bradymiller wrote on Thursday, May 08, 2014:

Hi,
Found some issues and am actively working on these issues in this branch:


-brady
OpenEMR

bradymiller wrote on Sunday, May 11, 2014:

Hi Jan (and testers),

Have made some modifications to the code, which appears to be testing well, which are on the following branch:

The first two commits are likely ready to go to official codebase after further testing and review. Jan, check out the following commit, which shows what I changed in your code:

Can test on following Up For Grabs demo:
http://www.open-emr.org/wiki/index.php/Development_Demo#192.168.1.134

Jan, the third commit still needs some work (this commit is bringing in the new languages and language codes). The last thing that need to deal with are changing the seq codes in the upgrade script. We should make this rather strict. For example for Armenian:

#IfRow3D list_options list_id language seq 10 option_id armenian
UPDATE 'list_options' SET 'seq' = '90' WHERE 'option_id' = 'armenian';
#EndIf
#IfRow3D list_options list_id language seq 10 title Armenian
UPDATE 'list_options' SET 'seq' = '90' WHERE 'title' = 'Armenian';
#EndIf

(Do note that you need to create a new function called IfRow3D in the metalanguage to support this: library/sql_upgrade_fx.php )

Woohooo, this is getting very close to being complete :slight_smile:
-brady
OpenEMR

bradymiller wrote on Monday, May 19, 2014:

Hi Jan,

I just committed two of the items to sourceforge, so this is now 75% complete. All that is left to do is to deal with list of languages:
https://github.com/bradymiller/openemr/commit/9d3116969e24eca4b1c0744b2649018f095ec504

Two things to deal with:
1.As discussed in above post, deal with changing the seq codes in the upgrade script. We should make this rather strict. For example for Armenian:

#IfRow3D list_options list_id language seq 10 option_id armenian
UPDATE 'list_options' SET 'seq' = '90' WHERE 'option_id' = 'armenian';
#EndIf
#IfRow3D list_options list_id language seq 10 title Armenian
UPDATE 'list_options' SET 'seq' = '90' WHERE 'title' = 'Armenian';
#EndIf

(Do note that you need to create a new function called IfRow3D in the metalanguage to support this: library/sql_upgrade_fx.php )

2.For the languages that were dropped (ie. in old list, but not in the new list), if a code exists, place a code, and also set the seq to properly alphabetize it(again, as above be strict and only do it if the seq matches original entry).

-brady
OpenEMR