Committed initial UI enhancements to trunk

rachoac wrote on Thursday, January 07, 2010:

Hi Folks,

I’ve committed to trunk the UI enhancements to the demographics pages (demographics.php, demographics_full.php), left nav, and top nav (main_title.php), introducing modals and tabbed view user experiences to OpenEMR. Have a look. The original code review can be found here: https://sourceforge.net/tracker/?func=detail&aid=2925117&group_id=60081&atid=1245239

Files which were modified include:

M controllers/C_Prescription.class.php
M interface/main/left_nav.php
M interface/main/main_title.php
M interface/patient_file/deleter.php
M interface/patient_file/summary/demographics.php
M interface/patient_file/summary/demographics_full.php
A interface/patient_file/summary/pnotes_fragment.php
M interface/patient_file/summary/stats.php
M interface/themes/style_sky_blue.css
M library/options.inc.php
A library/js/common.js
A library/js/jquery.1.3.2.js
A library/js/fancybox/fancy_closebox.png
A library/js/fancybox/fancy_left.png
A library/js/fancybox/fancy_progress.png
A library/js/fancybox/fancy_right.png
A library/js/fancybox/fancy_shadow_e.png
A library/js/fancybox/fancy_shadow_n.png
A library/js/fancybox/fancy_shadow_ne.png
A library/js/fancybox/fancy_shadow_nw.png
A library/js/fancybox/fancy_shadow_s.png
A library/js/fancybox/fancy_shadow_se.png
A library/js/fancybox/fancy_shadow_sw.png
A library/js/fancybox/fancy_shadow_w.png
A library/js/fancybox/fancy_title_left.png
A library/js/fancybox/fancy_title_main.png
A library/js/fancybox/fancy_title_right.png
A library/js/fancybox/jquery.fancybox-1.2.6.css
A library/js/fancybox/jquery.fancybox-1.2.6.js
A library/js/fancybox/jquery.fancybox-1.2.6.pack.js
A templates/prescription/general_fragment.html

Thanks,

Aron

bradymiller wrote on Thursday, January 07, 2010:

hey,

I just reset the cvs (3.3.x) demo, so can now see this stuff on the demo (I couldn’t wait until AM). very cool.

-brady

rachoac wrote on Thursday, January 07, 2010:

Thanks Brady!

blankev wrote on Thursday, January 07, 2010:

Looks nice and a rather low learning curve, but for experienced users a new way of clicking. But I saw that at least the Dutch translations need some corrections since the length of the fields seem to matter, more so than in the tree view V3.1

I also tried to include some photographs and encountered aflawless load but no show. So it is obvious the Images should be of some specified type in the sub-directory: Patient Photograph.

Can we add the specifications in the load document page or will it be adequate to mention the specifications in the wiki-FAQ?

I uploaded a moving *.gif of 100x100 no problem and works even as a running picture. But in V 3.1 I loaded a huge picture without problems, but it did not work for this V 3.3 new UI interface. It seems to be a bit more restricted.

Please send me all options and restrictions in size and type so I can include them in the FAQ as starters.

Brady can you load the latest translations into V 3.3 so I can compare what to change with my latest translations since yesterday……

TNX Pimm

aperezcrespo wrote on Thursday, January 07, 2010:

Hi

Really, really cool and needed.

How will this affect or how can we use this in custom forms?

Thanks

bradymiller wrote on Thursday, January 07, 2010:

Pimm,

Gonna focus translations on 3.2 until the release for several reasons:
1) 3.3 is very much in flux and constants can change. Once a constant gets to spreadsheet, it is permanent; this mechanism is built into the translation scripts to ensure new tables are always compatible with old version of openemr.
2) I only have time to add new constants and produce the tables every 2-3 weeks (that’s even stretching it)

-brady

ytiddo wrote on Thursday, January 07, 2010:

an update to this has way broken my local tree here.

In the demographics page, clicking on any of the section names sends me to /play/javascript-tabbed-navigation/

I’m hoping the look is because of the broken javascript, because the way this looks…
well, it looks like the whole tabbed concept is breaking in my browser (newest iceape from debian unstable)
the collapsable sections look nice, but the page as a whole jooks jagged. it may be a result of the tabbed object breaking, or…

I’m going to continue debugging on my end…

just for my sanity, did you guys do any runs by the w3c validator? the form generator i’ll be releasing to public demo next week generates xhtml1.1/CSS3 compliant code, to avoid situations like this…

Justin Doiel

rachoac wrote on Friday, January 08, 2010:

Hi Justin,

Strange … on Ubuntu 8.10, on SeaMonkey 1.1.17 (which is what I got when i did apt-get install iceape), things are rendering just fine. Anybody else seeing weird breakage?

Aron