bradymiller wrote on Friday, June 17, 2016:
Thanks Rod,
Here’s a good one for you (since it’s using LBF engine):
Matrix data entry validation.
(try to ignore the commit madness and focus on the code changes 
)
-brady
OpenEMR
bradymiller wrote on Friday, June 17, 2016:
Hi,
If anybody else want to be “matched” to code that needs to be reviewed, please just let me know. I guarantee a 100% match rate
-brady
OpenEMR
bradymiller wrote on Friday, August 26, 2016:
Hi,
Anybody want to take on this review:
It’s a very neat mechanism where an automated tool (AppChecker) picks out obvious bugs (this is the 2nd time it has happened). Its should be an easy review if anybody is interested.
thanks,
-brady
OpenEMR
teryhill wrote on Friday, August 26, 2016:
They look like good catches to me
From: Brady Miller <bradymiller@users.sf.net>
To: [openemr:discussion] 202506@discussion.openemr.p.re.sf.net
Sent: Friday, August 26, 2016 5:54 AM
Subject: [openemr:discussion] Code Reviews
Hi,
Anybody want to take on this review:
It’s a very neat mechanism where an automated tool (AppChecker) picks out obvious bugs (this is the 2nd time it has happened). Its should be an easy review if anybody is interested.
thanks,
-brady
OpenEMR
Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/openemr/discussion/202506/
To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/
sunsetsystems wrote on Friday, August 26, 2016:
Yes, seems fine. Is dupecheck documented anywhere?
bradymiller wrote on Monday, August 29, 2016:
Thanks for the feedback. Brought in those commits. Couldn’t find any dupecheck documentation.
bradymiller wrote on Monday, August 29, 2016:
Hi,
We are getting behind again on the review process (there has been an eclipse of the MU2 deadline and planned 5.0.0 release that have been taking up resources).
If anybody is up for it, here are two PR’s that could use reviewing:
-1. https://github.com/openemr/openemr/pull/204
(this is code by MD Support to add persistence of user choices along with some nice optimization of code)
-2. https://github.com/openemr/openemr/pull/207
(this is code by Matrix to have option to have several more logos on the login page)
thanks,
-brady
OpenEMR
juggernautsei wrote on Thursday, September 01, 2016:
Thanks for the heads up about the phpstorm. I’ll start using it today.
I think the drop and drag should be pulled off the list. I myself have found security flaws with it.
bradymiller wrote on Thursday, September 01, 2016:
just remove the drop and drag from the list.
bradymiller wrote on Thursday, September 01, 2016:
Hi,
Pull requests are coming in quicker and quicker(about 6 just in the last 24 hours…).
Now that we are migrating to github, one of the benefits is flagging pull request that need to be reviewed. So, basically this link will show all PR’s that need a code review:
So, click the link and pick a PR to review
thanks,
-brady
OpenEMR
sunsetsystems wrote on Thursday, September 01, 2016:
Reviewed #212.
sunsetsystems wrote on Thursday, September 01, 2016:
Added some comments to #222, did not test.
bradymiller wrote on Wednesday, September 21, 2016:
Hi Everybody,
Starting to get behind on code reviews. Please participate in the code reviews. List of submissions that need code review are here:
thanks,
-brady
OpenEMR
bradymiller wrote on Thursday, November 10, 2016:
Hi Everybody,
Getting behind on code reviews again. Please participate in the code reviews. List of submissions that need code review are here:
thanks,
-brady
OpenEMR