Code Reviews

bradymiller wrote on Friday, April 22, 2016:

Hi,

For many months, the code submissions have been rolling in (which is a great thing). However, it’s been difficult keeping up and some really nice features(for example Ray’s eye form which is simply revolutionary) keep getting delayed. For example, here is my current code review queue:
REVIEW QUEUE:
EXPEDITE:
nothing
NORMAL:

  1. Terry Exclude Insurance
  2. Ray Eye Form
  3. Sherwin prior auth form
  4. Visolve multi-provider bug fix
  5. Tony floating alerts
  6. Sherwin labs form
  7. MD Support PE form
  8. Terry HFCA printout
  9. Sherwin document drag and drop
  10. Art x10 4010 smackdown
  11. Terry Patient Portal Appt Scheduling (check with Terry if ready for a review)
  12. Terry Insurance Inactivate code (waiting for toggle change)
  13. MD Support Apps choices in login (Kevin and Rod review pending)

Figured it is a good time to begin brainstorming on ideas to encourage/motivate developers to participate in the code reviews? Please post your thoughts.

-brady
OpenEMR

fsgl wrote on Friday, April 22, 2016:

For starters, you may wish to delegate some of the responsibility by moving a few of the developers up the hierarchy.

Terry Hill & Ian Jardine (such an eco-friendly surname) are two names that come to mind. (Terry, your surname would be considered agrarian, if it had been terraced.)

I’m in no position to comment on their coding habits, but the 2 men’s common sense, even temperament & diligence would recommend them for consideration.

teryhill wrote on Friday, April 22, 2016:

Thanks Mouse for the vote, but I am not versed enough as a programmer to adequately review the code for the code base. I am just a hack at best. Rod, Brady and Tony are the top canines for committing the code. I don’t believe Brady’s bottleneck is committing the code to the codebase but it is debugging it, testing it and bringing it to the standards of the codebase. Perhaps the vendors on the certified support page could help with a greater commitment in this area they are after all reaping a harvest from this project.

I can at best just chunk out small fixes till someone with greater abilities than mine comes forward to takeover this effort.

In Service
Terry

fsgl wrote on Friday, April 22, 2016:

Not even having a GitHub account, I can’t question your modesty.

Brady is by far more capable with any assessment.

Many hands make light work, be it yours or that of any other deserving soul.

yehster wrote on Friday, April 22, 2016:

For item 13 (Apps mode) the approach is not sound for many reasons, and the commit does not warrant inclusion or further review.

It’s a neat idea, though. The same functionality could be cleanly implemented with @media specific CSS that hides the nav and title frames in appropriate situations.

sunsetsystems wrote on Friday, April 22, 2016:

Brady, thanks for the list. I’ll try to help out a bit this weekend.

Rod
http://www.sunsetsystems.com/

yehster wrote on Friday, April 22, 2016:

Re #7
Copy Forward (Copy and Paste) is a bit of Pandora’s box when it comes to clinical documentation.

As implemented for physical examinations, it fails AHIMA guidlines:

http://library.ahima.org/doc?oid=87789#.VxpUr0eKRzU

Based on external and independently verifiable sources, such as basic demographic information that is stable over time

Clearly and easily distinguished from original information, such as automatic summaries that populate data fields that are clearly identified as nonoriginal and cannot be mistaken for original information

Not actually rendered as part of the record until after a re-authentication process and also auditable for identifying actual origination

The joint commission would also probably frown on this feature too.

My position is not to bring this feature into the code base based on the recommendations of AHIMA and the Joint Comission.

tmccormi wrote on Friday, April 22, 2016:

All,
I’m happy to help but I’m more of a big picture, “Does this feature make sense and is the logic good” kind of guy. The language translation, syntactial and injection stuff is (for some reason) invisible to me. :slight_smile:

I think we should be using a automated review tool for much of this. There are tools for that, they are not perfect but they may help lighten the load.

PhpStorm does a great job of catching bad, deprecated and ill formed code if more developers used tools like that we would get a cleaner code base.

mdsupport wrote on Friday, April 22, 2016:

This code copies previous normal/abnormal settings and observation details from last form but does not save it. I am not sure if asking the physician to type in same comments for chronic conditions is going to improve quality of care - specially when they are to save, review and e-sign those . By same logic one could argue that every issue should be specific to a single encounter and physician should start every encounter with a clean slate!

mdsupport wrote on Friday, April 22, 2016:

What we really need is an API that lets external application to validate login, get ACL and session variables (if requested). Real target here is not to strip decorations from existing desktop oriented screens but enable mobile-specific apps with dedicated but limited functionality.

bradymiller wrote on Saturday, April 23, 2016:

Hi,
From a clinician practical standpoint, the copy/paste mechanism is used in notes and for good reasons; of course, it can go astray if overly done, but we should leave that up to the user/physician’s discretion.(as an example, in my dictations, about half of the note is copy/pasted from the prior note; if somebody told me I couldn’t do that I would not be happy, because then a stable PMH history section would be lost which is very valuable clinically for covering doctors or when the patient gets seen in the ED or admitted to the hospital)
-brady

yehster wrote on Saturday, April 23, 2016:

But what being copied and pasted here is a physical exam, for which new observations must be made every time.

Even for chronic conditions the findings are not necessarily stable. With asthma a wheeze might be present one visit and absent on another. The exam might vary because of time constraints on the physician himself.

Issues are a subset of PMH and are more reasonable to be copied forward as history is cumulative.

The Joint Commission and AHIMIA both acknowledge that copy and paste is appropriate for some documentation, hence the links I shared provide guidance rather than simply forbidding the practice.

bradymiller wrote on Saturday, April 23, 2016:

Hi,

I have also copy/pasted the physical exam on occasion (the problem with that on a dictation is that the vitals are in it; if didn’t have this issue, I would do it much more). It’s rather typical for a physical exam to not change from visit to visit for follow up visits(of course, this is dependent on the practice/speciality). From a philosophical perspective, I think it will be better to fall on the side of the physician/user rather than the folks in high towers(ie. leave these types of decisions to the ones in the trenches).

If this is changing the behavior of an old form, though, would recommend making this a global option that can be turned on/off.

Note the LBF/Layouts does have an option to default to previous value, so the demand is there.

-brady

fsgl wrote on Saturday, April 23, 2016:

We have had a previous discussion about cloning the H & P.

Ideally we should write our clinical notes as we did as 4th year medical students with an abundance of detail. As we gain experience, the H & P becomes more compact & succinct, requiring fewer words to convey the essence of our findings.

When physicians are struggling to adapt to their new EHR’s, the luxury of a 15 page H & P is only available to those with few patient responsibilities.

As long as there is not wholesale cloning of the clinical note, verbatim; copy/paste or more preferably, autocomplete of recurrent phrases, is an inevitable result of having to see too many patients in too short a period of time while trying to be compliant with government mandates.

We, as physicians, certainly know how to care for our patients & how to document that care properly, because we spent 8+ years learning that art. Unforturnately those, without the training nor the experience, have it in their heads that they know better.

yehster wrote on Saturday, April 23, 2016:

At the very least, the feature needs a toggle in globals and be disabled by default

A brand new user to OpenEMR could get themselves in trouble if they don’t realize the PE is being cloned.

sunsetsystems wrote on Monday, April 25, 2016:

Re #13, I agree with Kevin and previously commented in the ticket that a different approach is needed.

Rod
http://www.sunsetsystems.com/

sunsetsystems wrote on Monday, April 25, 2016:

Re #3, I don’t see a ticket or a place to make general comments. I have this comment:

The “Misc Billing Options HCFA” has a “BOX 23. Prior Authorization No.” field and if I recall correctly, was designed to replace and enhance the Prior Auth form. It is referenced by the $billing_options variable in library/Claim.class.php. Seems like the thing to do is improve that form and not the Prior Auth form.

Rod
http://www.sunsetsystems.com/

EDIT: I found the thread for this topic and added these comments.

bradymiller wrote on Tuesday, April 26, 2016:

BTW,

Here’s the github code pull request regarding the “Prior Auth” item:

-brady

bradymiller wrote on Wednesday, June 15, 2016:

Hi,

Another call for code reviews.

Here’s the most recent queue of pending code reviews:

  1. ZH Healthcare MU2 Immunizations(plan to commit this to codebase very soon).
  2. Terry duplicate appt bug fix(and other fix in tracking report)(minor and no need for others to review).
  3. Matrix document image thumbnails.
  4. Matrix data entry validation.
  5. Ray eye form.
  6. MD Support onsite patient portal signon update.
  7. Matrix custom assets management; loading of custom js/css into every script.
  8. Terry mod of floating alerts.
  9. Terry exclude insurance.
  10. Visolve multi-provider bug fix.
  11. MD Support PE form.
  12. Terry HFCA printout.
  13. Sherwin document drag and drop.
  14. Art x10 4010 smackdown.
  15. Visolve layout buttons (waiting for theme fixes by Robert).
  16. Terry patient portal app scheduling (check with Terry if ready for a review).
  17. Sherwin prior auth form (issue has been brought up by Rod).
  18. Sherwin labs form (issues have been brought up by Terry and Arnab).

Please, please, please, please feel free to review any of the code review requests listed above. Again, please… :slight_smile:
If need a link to find the code, just ask.

With the 2 goals of 1) maintaining my sanity and 2) to not lose track of any code review requests, I maintain the above list on below website (the website is served via “github pages” which is super easy for me to modify the list as items change etc.). Just let me know if your code review request is not on that list:
http://www.bradymd.com/todo/#openemr-code-reviews

-brady
OpenEMR

sunsetsystems wrote on Thursday, June 16, 2016:

Brady why don’t you assign a couple of things to me to review. Who else would also be OK with this?

Rod
http://www.sunsetsystems.com/