Code review: improvements for incoming electronic lab results

OpenEMR Development
1

sunsetsystems wrote on Wednesday, April 15, 2015:

I have ported some recent work with important improvements for lab results to current dev code. They are the most recent 6 commits here:

https://github.com/sunsetsystems/openemr/commits/somefixes

This is to give other developers the opportunity for code review before I push to SF. I hope the commit titles are reasonably explanatory - just let me know if any questions.

Rod
http://www.sunsetsystems.com/

2

mdsupport wrote on Wednesday, April 15, 2015:

Please consider the possibility that there could be valid duplicate patient records with

  1. Identical names and dob
  2. Practice has chosen to not store SSNs for security reason

Another real life twist is of course is patient data duplication where all patient data will match…

3

sunsetsystems wrote on Wednesday, April 15, 2015:

So you’re saying to check if more than one patient matches incoming results on first and last name and DOB, and SSNs are not used, and to require user intervention in that case?

That sounds reasonable. Thanks.

Rod
http://www.sunsetsystems.com/

4

bradymiller wrote on Thursday, April 16, 2015:

Hi,
The strtoupper() won’t work for utf8 characters (for example, special spanish characters and other more obvious chinese characters). I don’t think it’s much of an issue, because it likely just returns the original form if doesn’t find a mapping, but could run a special spanish and a greek character through it to see what happens; would hate to see it turn into gibberish.
-brady
OpenEMR

5

sunsetsystems wrote on Friday, April 17, 2015:

I’ve made a couple of suggested improvements, rebased it all into 2 commits and pushed to SF. Thanks to Brady and MD Support for the comments and suggestions!

Rod
http://www.sunsetsystems.com/

6

arnabnaha wrote on Friday, April 17, 2015:

hi Rod,

Thanks for the improvement in the labs…I applied your new changes from github. After going to electronic results and searching for a lab result, if we click on the date (which is hyperlinked) it gives a blank white page. See attachment below

Has the date been hyperlinked for a purpose? if not, then you can change the date to non clickable form. BTW, the patient redirect works flawlessly from the electronic result page. Thank you so much for that

7

sunsetsystems wrote on Sunday, April 19, 2015:

Hi Arnab, yes it’s on purpose and is supposed to bring up the results window. Might be a bug, I’ll take a look.

Rod
http://www.sunsetsystems.com/

8

sunsetsystems wrote on Sunday, April 19, 2015:

I checked in a fix. The bug was introduced by this commit dated April 1:

Rod
http://www.sunsetsystems.com/