Code review for a fix to the file export from the backup menu

teryhill wrote on Thursday, June 25, 2015:

I have made some changes to Rod’s export routine for lists and layouts so it will work with windows.
the main commit is here

I made the change that Rod requested. I need some linix users to check it and make sure I did not break anything for that OS. I need some Windows users to make sure it will work for that OS.

I am giving some thought on how to make the import a little less user vicious and any Ideas would be welcomed. Like may be coming up with a way to let you know that the id number is already used and give the option to change it or if it is used just use the next available (don’t know what’s doable at this point)

Terry

arnabnaha wrote on Friday, June 26, 2015:

Hi Terry,

i copied the backup.php file on to my production files and tried a backup but it hanged in the midway.

I am on windows…but the backup doesnt seem to work

It shows - Openemrbackup is ready, sending download now and then the page shows a smiley (attachment below)

teryhill wrote on Friday, June 26, 2015:

Depending on your computer the backup can take a while. on my laptop with 10 patients it takes 15 minutes to complete. I did not make any changes to the Backup function. I made changes to the export of the lists and layouts. If you have not done so you will need to turn on this feature via Globals on the feature tab by checking Configuration Export/Import

Terry

bradymiller wrote on Sunday, June 28, 2015:

Hi Terry,
Placed a comment on github.
-brady
OpenEMR

teryhill wrote on Sunday, June 28, 2015:

Made the changes and tested on my windows box it works here.
Also I don’t think I mentioned that I did some more work on the report files for the binding and made a commit on it.
And one last question , are my commits coming across ok now?
Terry
From: Brady Miller bradymiller@users.sf.net
To: [openemr:discussion] 202506@discussion.openemr.p.re.sf.net
Sent: Sunday, June 28, 2015 4:06 AM
Subject: [openemr:discussion] Code review for a fix to the file export from the backup menu

Hi Terry,
Placed a comment on github.
-brady
OpenEMR


Code review for a fix to the file export from the backup menu


Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/openemr/discussion/202506/

To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/