robertovasquez wrote on Monday, September 01, 2014:
Hi Jan
Your commit do not include my last commit.
case “togglePlanStatus” and function togglePlanStatus on / RulesPlanMappingEventHandlers.php are not updated with my last commit. The same at plans_config.php
What is going to happen with the code left behind?
bradymiller wrote on Monday, September 01, 2014:
We definitely need to ensure no code was lost. Was this code in the branch that Jan just rebased from:
bradymiller wrote on Monday, September 01, 2014:
Hi Jan,
If Roberto’s above code was not in your prior branch, then I would suggest cherry-pick command rather than merge command when bringing in Roberto’s commits into your branch.
-brady
OpenEMR
robertovasquez wrote on Sunday, September 07, 2014:
I took a look of the last cdr-plans-admin_gui_v2 last commit. All the code is there. Good Job Jan
jansta23 wrote on Sunday, October 05, 2014:
Revisions after code review have been completed.
bradymiller wrote on Wednesday, November 19, 2014:
Hi Jan and Roberto,
Sorry for the delay, but I finally got around to reviewing this code. I rebased your code into one commit and reviewed it here(note only several minor issues to fix):
-brady
OpenEMR
bradymiller wrote on Sunday, February 15, 2015:
Hi,
I just committed Jan and Roberto’s feature into the codebase. Thank you Jan and Roberto for this new feature!
For more info on this feature, see here:
http://www.open-emr.org/wiki/index.php/Active_Projects#Integrate_Plans_into_the_Admin_GUI
-brady
OpenEMR