sunsetsystems wrote on Thursday, January 28, 2010:
I have not had time to try getting this stuff running, do you have a demo?
I skimmed most of the code. This is good stuff and carefully done. I’m impressed. I like the approach of using stored procedures to accomplish background processing. One concern is, will it work with other databases such as PostgreSQL, or can it be easily adapted to do so? Also have you tested backup and the companion restore script to make sure they still work?
You don’t get off scott-free with the code, I do have a couple of nits to pick. 
Regarding de_identification_screen1.php:
* This code and others need a lot more comments. The goal here is to help the newcomer to your code understand the overall logic of what’s going on.
* Regarding this line and many others like it:
alert("<?php echo xl(‘End date should be greater than Begin date’);?>");
Be careful when you create a quoted literal that might contain something you have no control over, in this case a translated string. If the translation includes a quote, the code will crash and someone is going to have a big support headache. Better would be:
alert("<?php echo addslashes(xl(‘End date should be greater than Begin date’)); ?>");
(thinking about this, addslashes() is not ideal for this purpose; we probably want a custom function that deals with quotes as well as newline characters).
* Regarding this and other places:
<table style=“width: 500px;border:1px solid #0000FF;” align=“center” >
Best to avoid specifying widths and heights in pixels. The problem is that as monitors get better and with higher resolutions, these things will get tinier. In most cases it’s best to use either points or percentage.
Nice job!
Rod
www.sunsetsystems.com